Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Add detection of uno.sdk.private #18739

Merged
merged 1 commit into from
Nov 8, 2024
Merged

chore: Add detection of uno.sdk.private #18739

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions src/Uno.UI.RemoteControl.VS/GlobalJsonObserver.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,17 +1,12 @@
using System;
using System.IO;
using System.Text.Json;
using System.Linq;
using System.Threading.Tasks;
using EnvDTE;
using Microsoft.VisualStudio.Imaging;
using Microsoft.VisualStudio.Shell;
using EnvDTE80;
using Microsoft.VisualStudio.Shell.Interop;
using Uno.UI.RemoteControl.VS.Helpers;
using Microsoft.VisualStudio.PlatformUI;
using Uno.UI.RemoteControl.VS.Notifications;
using Microsoft.VisualStudio.Imaging;
using Microsoft.VisualStudio;
using System.Threading.Tasks;

namespace Uno.UI.RemoteControl.VS;

Expand Down Expand Up @@ -176,6 +171,11 @@ await _asyncPackage.GetServiceAsync(typeof(SVsShell)) is IVsShell shell
{
return unoSdkElement.ToString();
}
// Can't find Uno.Sdk, so fallback to look for Uno.Sdk.Private
if (msbuildSdksElement.TryGetProperty("Uno.Sdk.Private", out var unoSdkPrivateElement))
{
return unoSdkPrivateElement.ToString();
}
}

return null;
Expand Down
Loading