Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Avoid duplicated logs and prevent error bubbling #18746

Merged
merged 1 commit into from
Nov 9, 2024

Conversation

dr1rrb
Copy link
Member

@dr1rrb dr1rrb commented Nov 8, 2024

Chore

Avoid duplicated logs and prevent error bubbling

What is the current behavior?

  • Errors might logged twice
  • Once logged, error are re-thrown driving to unknown behavior

What is the new behavior?

  • Errors logged only once
  • Once logged, errors are discarded

PR Checklist

Please check if your PR fulfills the following requirements:

@dr1rrb dr1rrb force-pushed the dev/dr/vsIdeChanErrors branch from 34eb925 to 9e38c7a Compare November 8, 2024 21:34
@jeromelaban
Copy link
Member

@Mergifyio backport release/stable/5.5

@jeromelaban jeromelaban enabled auto-merge November 8, 2024 21:36
Copy link
Contributor

mergify bot commented Nov 8, 2024

backport release/stable/5.5

✅ Backports have been created

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18746/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18746/index.html

@jeromelaban
Copy link
Member

/azp run

Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18746/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18746/index.html

@jeromelaban jeromelaban disabled auto-merge November 9, 2024 14:57
@jeromelaban jeromelaban merged commit 7bac422 into master Nov 9, 2024
106 of 109 checks passed
@jeromelaban jeromelaban deleted the dev/dr/vsIdeChanErrors branch November 9, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants