Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(dragdrop): don't fire Drop if AcceptedOperation is None #18808

Merged
merged 5 commits into from
Nov 22, 2024
Merged

fix(dragdrop): don't fire Drop if AcceptedOperation is None #18808

merged 5 commits into from
Nov 22, 2024

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes #18770

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added the area/skia ✏️ Categorizes an issue or PR as relevant to Skia label Nov 15, 2024
@ramezgerges ramezgerges requested a review from dr1rrb November 15, 2024 16:56
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18808/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18808/index.html

@github-actions github-actions bot added the platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform label Nov 19, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18808/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18808/index.html

@ramezgerges ramezgerges force-pushed the dragdrop_multiple_drop_targets branch from a73a88b to 218d6f9 Compare November 19, 2024 13:15
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18808/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18808/index.html

@ramezgerges ramezgerges merged commit c84629f into unoplatform:master Nov 22, 2024
114 of 115 checks passed
@ramezgerges ramezgerges deleted the dragdrop_multiple_drop_targets branch November 22, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@dr1rrb dr1rrb dr1rrb approved these changes

Assignees
No one assigned
Labels
area/skia ✏️ Categorizes an issue or PR as relevant to Skia platform/macos 🍏 Categorizes an issue or PR as relevant to the macOS platform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Drop event fires even if AcceptedOperation is set to None
4 participants
@ramezgerges @unodevops @dr1rrb @Youssef1313