Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(xamlgenerator): fix syntax error when using x:Uid #18880

Merged
merged 4 commits into from
Nov 27, 2024
Merged

fix(xamlgenerator): fix syntax error when using x:Uid #18880

merged 4 commits into from
Nov 27, 2024

Conversation

ramezgerges
Copy link
Contributor

GitHub Issue (If applicable): closes #18322

PR Type

What kind of change does this PR introduce?

What is the current behavior?

What is the new behavior?

PR Checklist

Please check if your PR fulfills the following requirements:

Other information

Internal Issue (If applicable):

@github-actions github-actions bot added area/code-generation Categorizes an issue or PR as relevant to code generation area/automation Categorizes an issue or PR as relevant to project automation labels Nov 21, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18880/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18880/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148053 has failed on Uno.UI - CI.

@github-actions github-actions bot removed the area/automation Categorizes an issue or PR as relevant to project automation label Nov 25, 2024
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18880/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18880/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 148350 has failed on Uno.UI - CI.

@ramezgerges
Copy link
Contributor Author

/azp run

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 2 pipeline(s).

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18880/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18880/index.html

@jeromelaban jeromelaban merged commit c9e3273 into unoplatform:master Nov 27, 2024
114 of 115 checks passed
@ramezgerges ramezgerges deleted the xamlgenerator_syntax_error_xuid branch November 27, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Youssef1313 Youssef1313 Youssef1313 left review comments

@jeromelaban jeromelaban jeromelaban approved these changes

Assignees
No one assigned
Labels
area/code-generation Categorizes an issue or PR as relevant to code generation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Using x:Uid in the ContentDialog main properties produces a compilation error
4 participants
@ramezgerges @unodevops @jeromelaban @Youssef1313