-
Notifications
You must be signed in to change notification settings - Fork 742
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Adjust [NotImplemented]
on PasswordVault
#18997
Conversation
Hide whitespaces when reviewing, switched these files to file-scoped namespaces |
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18997/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18997/index.html |
|
5076146
to
0202aa8
Compare
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-18997/index.html |
🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-18997/index.html |
|
@MartinZikmund Not a comment for the PR directly, but would it be possible to encrypt the data on WASM before storing on our side? When users would use this API it would store to the same local storage, but it would be at least automatically encrypted. |
@morning4coffe-dev unfortunately not, it is all on client side, so it would not be possible to encrypt securely in any way - as long as the app would be able to decrypt (and it has to for it to be useful), anyone with the assemblies in hand could too |
GitHub Issue (If applicable): closes #
PR Type
What kind of change does this PR introduce?
What is the current behavior?
PasswordVault
is always underlined as not implemented.What is the new behavior?
Underlined only on Skia & WASM
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Run
results.