Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Avoid subscribing to touch scroll events twice #19007

Merged
merged 3 commits into from
Dec 12, 2024
Merged

fix: Avoid subscribing to touch scroll events twice #19007

merged 3 commits into from
Dec 12, 2024

Conversation

MartinZikmund
Copy link
Member

@MartinZikmund MartinZikmund commented Dec 4, 2024 •
edited
Loading

GitHub Issue (If applicable): closes https://github.com/unoplatform/uno-private/issues/703

PR Type

What kind of change does this PR introduce?

  • Bugfix

What is the current behavior?

ScrollContentPresenter was duplicating its touch event subscriptions. Because of that it caused various issue - e.g. scrolling twice as fast as finger movement.

What is the new behavior?

We make sure to unsubscribe when a new subscription is requested.

PR Checklist

Please check if your PR fulfills the following requirements:

@MartinZikmund MartinZikmund marked this pull request as draft December 4, 2024 21:37
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149391 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/fix-scroll-touch branch from 726fb91 to ec13e92 Compare December 6, 2024 14:14
@MartinZikmund MartinZikmund self-assigned this Dec 6, 2024
@MartinZikmund MartinZikmund marked this pull request as ready for review December 6, 2024 15:43
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149619 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/fix-scroll-touch branch from 5a31773 to 5d2b512 Compare December 8, 2024 16:42
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149703 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/fix-scroll-touch branch from 5d2b512 to fd57add Compare December 9, 2024 19:38
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149824 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/fix-scroll-touch branch from fd57add to aaac06c Compare December 10, 2024 15:10
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 149916 has failed on Uno.UI - CI.

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 150010 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/fix-scroll-touch branch from 23aee3e to cb86bd2 Compare December 12, 2024 00:02
@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

⚠️⚠️ The build 150080 has failed on Uno.UI - CI.

@MartinZikmund MartinZikmund force-pushed the dev/mazi/fix-scroll-touch branch from cb86bd2 to d810a65 Compare December 12, 2024 09:00
@unodevops
Copy link
Contributor

🤖 Your WebAssembly Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-19007/index.html

@unodevops
Copy link
Contributor

🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-19007/index.html

@jeromelaban jeromelaban disabled auto-merge December 12, 2024 12:50
@jeromelaban jeromelaban merged commit ffdceac into master Dec 12, 2024
111 of 113 checks passed
@jeromelaban jeromelaban deleted the dev/mazi/fix-scroll-touch branch December 12, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeromelaban jeromelaban Awaiting requested review from jeromelaban

Assignees

@MartinZikmund MartinZikmund

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MartinZikmund @unodevops @jeromelaban