build: Enable CS1998 as error #9983
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
Youssef1313
force-pushed
the
issues/9962
branch
3 times, most recently
from
62b6a40 to
9aa0e46
Compare
Youssef1313
force-pushed
the
issues/9962
branch
4 times, most recently
from
753b288 to
a20a9a1
Compare
Youssef1313
commented
Sep 27, 2022
src/SamplesApp/SamplesApp.UITests/Windows_UI_Xaml_Input/Capture_Tests.cs
Show resolved
Hide resolved
Youssef1313
force-pushed
the
issues/9962
branch
6 times, most recently
from
3903070 to
bff9651
Compare
Youssef1313
commented
Sep 27, 2022
src/Uno.UI.RuntimeTests/IntegrationTests/dxaml/controls/appbar/AppBarIntegrationTests.cs
Show resolved
Hide resolved
Youssef1313
force-pushed
the
issues/9962
branch
from
bff9651 to
f7600ec
Compare
Youssef1313
force-pushed
the
issues/9962
branch
from
f7600ec to
b16e544
Compare
|
Thanks, this will be a very useful one! For the tests - yes, it is quite possible they were "fake passing" - seen that for ExecuteOnUIThread which was also previously sometimes accidentally called without await and caused us to think the tests were ok, even though they failed after they "finished" |
MartinZikmund
approved these changes
Sep 28, 2022
jeromelaban
reviewed
Sep 28, 2022
jeromelaban
reviewed
Sep 28, 2022
|
@jeromelaban Is this ready to merge? |
|
@jeromelaban Could you take a look please? Thanks! |
jeromelaban
approved these changes
Oct 11, 2022
|
I'll merge it after the .NET 7 PR |
|
#10019 is merged now! 🎉 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
auto-merge was automatically disabled
October 12, 2022 17:58
Head branch was pushed to by a user without write access
|
@MartinZikmund I resolved a small conflict and auto-merge got disabled. |
Reenabled 👍 |
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
GitHub Issue (If applicable): closes #9962
PR Type
What kind of change does this PR introduce?
What is the current behavior?
What is the new behavior?
PR Checklist
Please check if your PR fulfills the following requirements:
Screenshots Compare Test Runresults.Other information
Internal Issue (If applicable):