feat: add coep, corp, x-dns-prefetch-control, x-permitted-cross-doman-policies #102
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unrolled
requested changes
Oct 19, 2024
| @@ -84,7 +84,10 @@ s := secure.New(secure.Options{ | |||
| FeaturePolicy: "vibrate 'none';", // Deprecated: this header has been renamed to PermissionsPolicy. FeaturePolicy allows the Feature-Policy header with the value to be set with a custom value. Default is "". | |||
| PermissionsPolicy: "fullscreen=(), geolocation=()", // PermissionsPolicy allows the Permissions-Policy header with the value to be set with a custom value. Default is "". | |||
| CrossOriginOpenerPolicy: "same-origin", // CrossOriginOpenerPolicy allows the Cross-Origin-Opener-Policy header with the value to be set with a custom value. Default is "". | |||
|
|
|||
| CrossOriginEmbedderPolicy: "require-corp", // CrossOriginEmbedderPolicy allows the Cross-Origin-Embedder-Policy header with the value to be set with a custom value. Default is "". | |||
There was a problem hiding this comment.
These need to be added to the defaults section below
There was a problem hiding this comment.
Thank you for the review. Addressed it here c4f1c0a.
secure.go
Outdated
| } | ||
|
|
||
| // X-DNS-Prefetch-Control header. | ||
| if s.opt.XDNSPrefetchControl { |
There was a problem hiding this comment.
Currently with the logic below, everyone using this library will be setting the X-DNS-Prefetch-Control header to off which we will want to avoid. This should be an opt in header with a length check like the others.
unrolled
approved these changes
Oct 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.