-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add firebase auth #386
Open
arnard76
wants to merge
11
commits into
dev
Choose a base branch
from
385-add-firebase-auth
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Add firebase auth #386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erver don't want think more about it loool https://nextjs.org/docs/app/api-reference/functions/use-search-params
arnard76
added
project: global
a project-wide issue
project: frontend
an issue in the frontend app
project: backend
an issue in the backend app
type: security
an issue that involves security
labels
Jun 23, 2024
Drafted in case clients want to keep the site live |
arnard76
requested review from
HuzzNZ,
sharukyen,
saamuelkim,
Gautham-27 and
junjunjun1
July 9, 2024 00:04
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
project: backend
an issue in the backend app
project: frontend
an issue in the frontend app
project: global
a project-wide issue
type: security
an issue that involves security
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task
Solution
Authentication in Firebase is similar to AWS Cognito but I noticed some differences so I chucked them below.
Firebase.Auth.-.Manual.Test.Passed.-.Copy.mp4
Firebase Authentication
and it will be a problem for client or future developers if that limit is reached
differences between Firebase Authentication & AWS Cognito:
Code changes
Backend
firebase/auth
toservices/services.ts
auth.controller.ts
validation/input.types.ts
Frontend
SignUpForm.tsx
: after creating an account, user now sees a message - 'confirmation email has been sent`forgot-password/page.tsx
: after sending themselves reset password email, user doesn't see a confirmation code input anymore. And the way they reset their password is with the link in email which goes to(auth)/firebase-actions/page.tsx
Alternative solutions
AWS Cognito (but not university's)
this would mean we don't need to refactor the changes above 😀
however AWS seems to require a payment source so would have to discuss how that works.
ideally, it shouldn't be a source that has any money otherwise our code might accidently spend it 😇
Auth0
free plan is a great alternative: https://auth0.com/pricing
no credit card either
looks like it supports username/password (+ email) like AWS cognito so less refactoring changes than firebase solution 🙂
any more ideas ?? 💡💡