detect signatures more accurately in newer PPI versions #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That is fantastic thank you for that. |
plicease
approved these changes
Dec 27, 2024
|
Cheers, glad you like it. :) Also, in case you're interested, i found this issue by way of our recursive dependents test. :D https://github.com/Perl-Critic/PPI/blob/master/.github/workflows/test-dependents.yml |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In versions > 1.279 PPI will more accurately determine the difference between prototypes and signatures, which breaks the test for the signature+@_ policy. This PR has a suggested fix for this. Once PPI is released, as per Perl-Critic/PPI#280 , you could also just fully depend on it.