-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Astro Integration #14
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change simplifies the function name for better readability and consistency. The adjustment aligns with naming conventions used across the codebase.
Moved Astro from dependencies to devDependencies for better clarity and management. This change keeps runtime dependencies cleaner and ensures Astro is used only in development environments.
Includes essential files such as `extensions.json`, `launch.json`, components, and layouts. Configures basic project structure, TypeScript settings, and environment variables with README documentation.
Co-authored-by: Fahreddin Özcan <88107904+fahreddinozcan@users.noreply.github.com>
Co-authored-by: Fahreddin Özcan <88107904+fahreddinozcan@users.noreply.github.com>
Co-authored-by: Fahreddin Özcan <88107904+fahreddinozcan@users.noreply.github.com>
Reordered function parameters in routeFunction call to match new signature and added missing semicolons for code consistency. These changes ensure smoother API context handling and improve code readability.
@hckhanh the previous branch was mistakenly broken by a force push, carried the PR over here. And this looks almost final now. Thanks for the contribution! |
That's great. I hope it's going to be merged soon |
CahidArda
approved these changes
Nov 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Astro Integration to Upstash Workflow, enabling it to be used in Astro Endpoints.
Original work by @hckhanh, the original PR #11 was closed by mistake.