Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Amendments to Package manifests #136

Merged
merged 2 commits into from
Nov 25, 2023
Merged

Amendments to Package manifests #136

merged 2 commits into from
Nov 25, 2023

Conversation

daveverwer
Copy link
Contributor

Hi! I'd love to add this package to the Swift Package Index, but currently the Package.swift file does not parse using swift package dump-package, which is what we use to gather metadata from the manifest.

I noticed you have a Swift 4 manifest that works, and wondered if it might be appropriate to move that across to be the primary manifest.

Thanks for considering the PR!

Pull Request Checklist

  • I've added the default copyright header to every new file.
  • Every new file has been correctly indented, no tabs, 4 spaces (you can use swiftlint).
  • You've read the contribution guidelines.

I have not added the copyright header as it wasn't there previously. I can add it if you would like, though.

@@ -1,5 +1,20 @@
// swift-tools-version: 5.6
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I picked 5.6 here as it's the lowest version we support on the package index. Of course, please feel free to reduce this to whatever you'd like to still support.

The only requirement we have is that swift package dump-package runs with the latest stable toolchain.

@uraimo
Copy link
Owner

uraimo commented Nov 25, 2023

Hi Dave, thanks! That was leftover from the Swift 3 days, I will merge this and lower it to 5.1 since there are still some users with that swift build.

@uraimo uraimo merged commit b504210 into uraimo:master Nov 25, 2023
1 check failed
@daveverwer
Copy link
Contributor Author

Thanks for the super speedy review and merge! I'll add it to the index now.

@daveverwer daveverwer deleted the patch-1 branch November 26, 2023 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants