Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support multiple GHEs in a single district #644

Draft
wants to merge 120 commits into
base: develop
Choose a base branch
from
Draft

Support multiple GHEs in a single district #644

wants to merge 120 commits into from

Conversation

vtnate
Copy link
Contributor

@vtnate vtnate commented Jul 11, 2024 •
edited
Loading

Any background context you want to provide?

Previously we only supported a single GHE in a thermal loop

What does this PR accomplish?

  • Reads all ghe_specific_params from the sys-param file
  • Instantiates a separate borefield object for each GHE
  • Couples the district together

How should this be manually tested?

  1. Build a Modelica model using the multi-ghe test
  2. Load the model in Dymola (by hand)
  3. Simulate in Dymola
    • OM crashes when trying to open a model that large :(

What are the relevant tickets?

Screenshots (if appropriate)

@vtnate vtnate added the enhancement New feature or request label Jul 11, 2024
@vtnate vtnate self-assigned this Jul 11, 2024
vtnate and others added 24 commits July 11, 2024 09:42
@vtnate
improve error message for missing g-function file
05a34db
@vtnate
additional g-function files to match the test sys-param files
a34f255
@vtnate
update borefield test to work in the multi-ghe paradigm
c5be9cc
@vtnate
improve help text in CLI
9508270
@vtnate
more explicitly process different types of district sys-params
390a88e
@vtnate
clean up generation call, load loop order, load multiple ghes
1d23f70
@vtnate
use new parameter for district_type argument
90a775b
@vtnate
load ghe loop order in the correct place
8df9749
@vtnate
move soil parameters out of ghe-specific and into all 5G parameters
a039d5b
@vtnate
use new location of soil parameters
7db291d
@vtnate
don't require soil in the incorrect place, duh
2d44053
@vtnate
use new fifth_generation tag properly in 5G tests
d669240
@vtnate
fix test sys-param files for 5G districts
47094c5
@vtnate
add graceful error message when sizing output from TN is not found
c5e75b8
@vtnate
remove outdated TODO message
364694b
@vtnate
remove unused test sys-param file
e1bb5c4
@vtnate
comment noisy debug log lines
07c30fa
@JingWang-CUB
update geojson and sys_param paths
00fcf08
@JingWang-CUB
add project folder for testing multi-ghe
b4883e9
@JingWang-CUB
update building load profiles
c0876c9
@JingWang-CUB
modify paths pointing to mos files and ghe_dir
649a00a
@JingWang-CUB
add ghe sizing results to ghe_dir
b76eaa8
@JingWang-CUB
move soil and add horizontal piping parameters
2a0134d
@vtnate
pre-commit formatting
d9d1f72
JingWang-CUB and others added 30 commits August 29, 2024 11:23
@JingWang-CUB
add new function for getting ghe_id
7b14aa4
@JingWang-CUB
fix jinja bugs
5bbdc8e
@JingWang-CUB
change model name
8a6d625
@JingWang-CUB
new function for getting the other model in the coupling
0b793a9
@JingWang-CUB
apply to connection pipe mass flow rates
fe77c12
@JingWang-CUB
fix coupling between borefield and dis
f254438
@JingWang-CUB
fix coupling between dis and ground coupling
61ff6a8
@JingWang-CUB
Merge branch 'ghe-couplings' of https://github.com/urbanopt/geojson-m…
91cf4e8 
…odelica-translator into ghe-couplings
@vtnate
linting
5fc399c
@vtnate
use ghe_id for borefield id & name
c84bd65
@vtnate
add comment for loading loop_order
b616df4
@vtnate
Merge branch 'develop' into ghe-couplings
6a97d80
@JingWang-CUB
continue using uuid for borefield
5b4dce1
@JingWang-CUB
new template for district data
724241e
@JingWang-CUB
coupling for district data
a3bcc1b
@JingWang-CUB
move datDes instance somewhere else
7e2f894
@JingWang-CUB
use loop_data to locate building order in loop for coupling
9fe4fcf
@JingWang-CUB
add connection between dis and next TIn
604a917
@JingWang-CUB
add additional couplings
1560fa6
@JingWang-CUB
this makes sure the model simulates
9d98017
@vtnate
update geojson & sys-params with ghe sizes to meet load
0cbdc96
@vtnate
hack to only keep a single autosize instance in Networks.order
c3f50f5
@vtnate
linting & formatting
8fbc189
@JingWang-CUB
align with how load_base name buildings
cf76bb7
@JingWang-CUB
fix for a single-ghe loop
65852f5
@JingWang-CUB
add additional instances and couplings
6dd8375
@JingWang-CUB
update content for single ghe test
75338d4
@JingWang-CUB
change ghe id to align with sys_params
2c865b6
@JingWang-CUB
fix for multi ghes
6dbd378
@JingWang-CUB
expand number of ports for multi ghes
f1855c6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vtnate vtnate

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vtnate @JingWang-CUB