Adds method to process modelica results #646
Conversation
There was a problem hiding this comment.
Please run pre-commit and address the linting & formatting changes.
Overall it's not clear to me what this command is for. Will you add more context to the PR description (and perhaps a bit to the cli command description) explaining what the output is, why someone would use this command, and how to interpret it?
| @@ -170,28 +171,28 @@ def create_model(sys_param_file: Path, geojson_feature_file: Path, project_path: | |||
| @click.option( | |||
| "-a", | |||
| "--start_time", | |||
| default=17280000, | |||
| default=15638400, | |||
There was a problem hiding this comment.
Why are you changing the defaults here? Did you mean to just pass these arguments to your call?
There was a problem hiding this comment.
this will be changed to run for a year with 15 min timesteps to overcome the openmodelica bug for 1 hour timesteps. We need to report a full year simulations for reopt.
There was a problem hiding this comment.
If we want to change the default timestep for all users, we can do that. That would be in --step-size, which was previously at 90 seconds before your change to 1 hour.
To change to running for a full year we'd change the start-time to 0 and the end time to whatever it is in seconds.
| :param start_time (int): start time of the simulation (seconds of a year) | ||
| :param stop_time (int): stop time of the simulation (seconds of a year) | ||
| :param step_size (int): step size of the simulation (seconds) | ||
| :param number_of_intervals (int): number of intervals to run the simulation |
There was a problem hiding this comment.
These are valid inputs to the run-model command, aren't they? Why remove them?
| """Post Process the model | ||
| \b | ||
| Post process results from Modelica project run previously, for GHP LCCA analysis | ||
| \b |
There was a problem hiding this comment.
Add a space above the \b for it to format as expected when you use it for real.
| """ | ||
| modelica_path = Path(modelica_project).resolve() | ||
| result = ResultsModelica(modelica_path) | ||
| result.calculate_results() |
There was a problem hiding this comment.
This took 2.5 hours to run on my laptop. Is that expected?
| print(csv_file_path) | ||
|
|
||
| # Check if the CSV file exists | ||
| assert csv_file_path.exists(), f"File does not exist at path: {csv_file_path}" |
There was a problem hiding this comment.
This generates a file as expected. I don't know if the contents are appropriate or not. Can you make some additional assertions so we'll know if the file has been populated correctly?
|
This needs to be incorporated |
what is the pre commit command? |
|
Objective :
This cli call takes the modelica folder created and run previously as an argument. It then reads the .mat file and queries timeseries results for heating, cooling electricity consumption of heat pumps, ets pump electricity consumption, pump associated with building electricity consumption loop pump electricity consumption and heat pump sizing for the GHP network.
To test :
Use
uo_des des-process 'modelica_model_name'Run
poetry run pytest tests poetry run pytest .\tests\geojson_modelica_translator\test_results_ghp.pyCheck the "geojson-modelica-translator\tests\geojson_modelica_translator\data\modelica_5\modelica_5.Districts.DistrictEnergySystem_results\modelica_5.Districts.DistrictEnergySystem_result.csv" file creeated with results queried for REopt GHP at 1 hour intervals.