Upgrade to OpenStudio 3.8 & Ruby 3.2 #275
Open
+49
−112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtnate
added
enhancement
Fixed(?) the regexp and core issue.
kflemin
approved these changes
Sep 5, 2024
| spec.add_runtime_dependency 'json-schema', '~> 2.7' | ||
| spec.add_runtime_dependency 'urbanopt-core', '~> 0.11.0' | ||
| spec.add_runtime_dependency 'json-schema', '~> 4.3.1' | ||
| # spec.add_runtime_dependency 'urbanopt-core', '~> 0.12.0' |
There was a problem hiding this comment.
we should clean this up (and the Gemfile) before merging
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #[issue number here]
Pull Request Description
The current version of OpenStudio, v3.8 includes a major breaking change to move from Ruby 2.7.2 to Ruby 3.2.2.
Checklist (Delete lines that don't apply)