adding residential geometry enhancement language updates #205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-robertson
requested changes
Jan 19, 2024
Comment on lines
+76
to
+77
| | orientation | number | North=0, East=90, South=180, West=270 | Customizable as of UO v0.11.0 | | ||
| | aspect_ratio | number | | Customizable as of UO v0.11.0. The ratio of front/back wall length to left/right wall length for the unit, excluding any protruding garage wall area. | |
There was a problem hiding this comment.
What about updating multifamily.md?
There was a problem hiding this comment.
Rawad ran into some complexities for Multifamily and did not update it yet. @rawadelkontar?
There was a problem hiding this comment.
What do you mean "did not update it yet"? Aren't orientation and aspect_ratio now available as inputs for any residential building type?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.