Remove node_modules from compiled version #187
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The compiled version, which is pushed to npm, contains a bundled version of
moment
, which makes it impossible to set the local from outside withbecause the internal
moment
version is not identical with the version you import from else where (see #149).To fix that problem I remove the
node_modules
folder from the compiled version. A little disadvantage is that you have to specifymoment
in you projectpackage.json
asdependencies
which means probably an breaking change.