-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Feature] Add ESLint to the project #1383
Conversation
@@ -133,11 +133,12 @@ export function get(source: any, path: string, ...fns: PredicateOrMapper[]) { | |||
case token === '..': | |||
case token === '.': | |||
break; | |||
case token === '?': | |||
case token === '?': { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@@ -43,8 +43,11 @@ function MyApp({ Component, pageProps }) { | |||
|
|||
if (!window.ipcRenderer) { | |||
return ( | |||
<div class="bg-red-100 border border-red-400 text-red-700 px-4 py-3 mx-10 my-10 rounded relative" role="alert"> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
class -> className
@@ -45,7 +45,6 @@ export default class QueryEditor extends React.Component { | |||
brunoVarInfo: { | |||
variables: getAllVariables(this.props.collection) | |||
}, | |||
theme: this.props.editorTheme || 'graphiql', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is no editorTheme
props being passed to this component on any of its occurrences
This is quite a significant change to the codebase, and given the current size of the PR backlog, I don't see us reviewing and merging this anytime soon. We'll chart out an effort later to incrementally adopt a linter in the future. |
Description
eslint .
in the desired directory.packages/bruno-electron/src/ipc/network/awsv4auth-helper.js
It seems that all those variables are being declared globally but maybe they could be declared as simple
const
s?packages/bruno-app/src/utils/importers/postman-collection.js
packages/bruno-app/src/utils/common/index.js
These seem like bugs
Contribution Checklist:
Closes: #1382
Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.
Publishing to New Package Managers
Please see here for more information.