Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

getContentType function and save file logic update #1499

Merged
merged 1 commit into from
Feb 1, 2024
Merged

getContentType function and save file logic update #1499

merged 1 commit into from
Feb 1, 2024

Conversation

therealrinku
Copy link
Contributor

@therealrinku therealrinku commented Feb 1, 2024 •
edited
Loading

Description

Closes: #1490
Previewing pdf and downloading wasn't working because response.headers was expected to be an array but it's an object

Contribution Checklist:

  • The pull request only addresses one issue or adds one feature.
  • The pull request does not introduce any breaking changes
  • I have added screenshots or gifs to help explain the change if applicable.
  • I have read the contribution guidelines.
  • Create an issue and link to the pull request.

before:
before.webm

After:
bruno.webm

@therealrinku therealrinku mentioned this pull request Feb 1, 2024
Closed
@helloanoop helloanoop merged commit 7b6c72c into usebruno:main Feb 1, 2024
2 of 3 checks passed
@helloanoop
Copy link
Contributor

Merged! Thank you @therealrinku !

@therealrinku therealrinku deleted the fix/preview branch February 1, 2024 15:05
@therealrinku therealrinku mentioned this pull request Feb 2, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preview and download is broken
2 participants
@therealrinku @helloanoop