Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(#1496) Allow ignoring path fragments from the collection configuration file #1514

Merged
merged 1 commit into from
Feb 4, 2024

Conversation

fredjeck
Copy link
Contributor

@fredjeck fredjeck commented Feb 3, 2024

Description

This PR resolves #1496 by enhancing the bruno.json collection configuration file with a new property named ignore allowing to specify a list of path fragments which should be excluded when loading a collection.

For instance :

{
  "version": "1",
  "name": "Sample Collection",
  "type": "collection",
  "ignore": [
  	".idea",
  	".vscode",
        "Test/Test2"
  ]
}

Collection creation behavior has also been updated so that default exclusions initially handled in the code (node_modules, .git folders) are now written by default in the collection configuration file.

Opening legacy collections will work as expected as default exclusions will be applied if no exclusion configuration can be found.

The collection info tab has been updated in order to display the list of excluded path items

image

Contribution Checklist:

  • [ X] The pull request only addresses one issue or adds one feature.
  • [ X] The pull request does not introduce any breaking changes
  • [ X] I have added screenshots or gifs to help explain the change if applicable.
  • [ X] I have read the contribution guidelines.
  • [ X] Create an issue and link to the pull request.

Note: Keeping the PR small and focused helps make it easier to review and merge. If you have multiple changes you want to make, please consider submitting them as separate pull requests.

Publishing to New Package Managers

Please see here for more information.

…owing to specify which files or folders should be ignored in the collection.

Also makes sure the behavior of legacy collections is not altered.

Fixes issue usebruno#1496
@fredjeck fredjeck changed the title Introduces a new bruno.json configuration property named 'ignore' all… Allow ignoring path fragments from the collection configuration file Feb 3, 2024
@fredjeck fredjeck changed the title Allow ignoring path fragments from the collection configuration file [Feature] Allow ignoring path fragments from the collection configuration file Feb 3, 2024
@fredjeck fredjeck changed the title [Feature] Allow ignoring path fragments from the collection configuration file feat(#1496) Allow ignoring path fragments from the collection configuration file Feb 3, 2024
@helloanoop helloanoop merged commit cb95b5f into usebruno:main Feb 4, 2024
2 of 3 checks passed
@helloanoop
Copy link
Contributor

Nice!
Merged. Thanks @fredjeck !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ignore common folders in collection
2 participants