Change HEAD to original after execution instead of staying on INPUT_BASEREF #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ntsk
changed the title
There was a problem hiding this comment.
Thanks! I left one minor comment. I can address it on my own later this week, and release it together with #105
(Please ignore the CI failure, I still haven't managed to sort the token permission issue 👀)
Thanks again!
| @@ -20,3 +22,5 @@ delimiter=$(openssl rand -hex 20) | |||
| echo "text-diff<<$delimiter" >> $GITHUB_OUTPUT | |||
| echo "$diff" >> $GITHUB_OUTPUT | |||
| echo "$delimiter" >> $GITHUB_OUTPUT | |||
|
|
|||
| git checkout "$current_head" | |||
There was a problem hiding this comment.
🔧
We probably should use git switch here, right?
Suggested change
| git checkout "$current_head" | |
| git switch "$current_head" |
There was a problem hiding this comment.
With actions/checkout, it automatically moves to a detached HEAD state. To align with this behavior, I chose to use git checkout.
However, I agree that git switch --detach "$current_head" could also be a viable alternative.
mateuszkwiecinski
added a commit
that referenced
this pull request
Jan 26, 2024
…ution Change HEAD to original after execution instead of staying on INPUT_BASEREF (Copy of #106)
|
Merged in #111, and included in https://github.com/usefulness/dependency-tree-diff-action/releases/tag/v2.0.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team performs lint checks following this action and summarizes the findings in comments on GitHub. Currently, the branch remains on INPUT_BASEREF after execution, which is an implicit behavior.
For better clarity and workflow consistency, we propose reverting back to the original HEAD once the action completes. This change ensures subsequent tasks run on the appropriate context of the original commit.