Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Corrected and added the indicators to determine the chemical rank #8

Open
wants to merge 15 commits into
base: 0.4.X
Choose a base branch
from
Open

Corrected and added the indicators to determine the chemical rank #8

wants to merge 15 commits into from
+146 −53

Commits on Jun 19, 2018

  1. Remoted the previous redundunt code to enhance readability 

    Also added TODOs for future correction
    @sshojiro
    sshojiro committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    907ade7 View commit details
    Browse the repository at this point in the history

  2. Inserted deepcopy

    @sshojiro
    sshojiro committed Jun 19, 2018
    Configuration menu
    Copy the full SHA
    8c5b4fb View commit details
    Browse the repository at this point in the history

Commits on Jun 20, 2018

  1. Modified IND function; however, the former implementation may contain… 

    … the errors
    @sshojiro
    sshojiro committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    bbf8d5b View commit details
    Browse the repository at this point in the history

  2. Inserted my name to the contributor list

    @sshojiro
    sshojiro committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    e9ba396 View commit details
    Browse the repository at this point in the history

  3. Included pca into __all__

    @sshojiro
    sshojiro committed Jun 20, 2018
    Configuration menu
    Copy the full SHA
    6e12027 View commit details
    Browse the repository at this point in the history

Commits on Jul 15, 2018

  1. Added RSD, an indicator to compute chemical rank, involved in IND 

    Added its test to validate the length of the computed vector
    @sshojiro
    sshojiro committed Jul 15, 2018
    Configuration menu
    Copy the full SHA
    0104cbb View commit details
    Browse the repository at this point in the history

  2. Eliminate redundant blank rows 

    Renamed clearer variables
    @sshojiro
    sshojiro committed Jul 15, 2018
    Configuration menu
    Copy the full SHA
    74295ae View commit details
    Browse the repository at this point in the history

  3. Update IND function using RSD, and ROD 

    Implemented the tests for the length of IND and ROD functions
    @sshojiro
    sshojiro committed Jul 15, 2018
    Configuration menu
    Copy the full SHA
    c59631f View commit details
    Browse the repository at this point in the history

Commits on Jul 25, 2018

  1. Updated rank code 

    PCA computation and RSD computation reduce the rank of the spectra by one respectively
    @sshojiro
    sshojiro committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    a29f613 View commit details
    Browse the repository at this point in the history

  2. Updated rank notebook along with the update of the indicator definitions

    @sshojiro
    sshojiro committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    df8895d View commit details
    Browse the repository at this point in the history

  3. Corrected a denominator value 

    Eliminated the needless path manipulation
    @sshojiro
    sshojiro committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    cfa12ae View commit details
    Browse the repository at this point in the history

  4. Updated documentation of the indicators

    @sshojiro
    sshojiro committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    2fe771c View commit details
    Browse the repository at this point in the history

  5. Merge pull request #3 from sshojiro/develop 

    Corrected the indicators for determination of the chemical rank
    @sshojiro
    sshojiro committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    720bc99 View commit details
    Browse the repository at this point in the history

  6. Resolved the conflict

    @sshojiro
    sshojiro committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    d5b83a0 View commit details
    Browse the repository at this point in the history

  7. Merge pull request #4 from sshojiro/develop 

    Resolved a conflict.
    @sshojiro
    sshojiro committed Jul 25, 2018
    Configuration menu
    Copy the full SHA
    d9e3a20 View commit details
    Browse the repository at this point in the history