Copy sensor base initialization from s2e-ff #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
200km
added
priority::medium
sksat
approved these changes
Nov 28, 2022
200km
deleted the
feature/copy-sensor-base-initialization-from-s2e-ff
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Copy sensor base initialization from s2e-ff
Issue
SensorBaseinS2E-FF#250Details
InitializeSensorBasewas copied.It helps users to easily make a new sensor component.
Validation results
See here
The function was just copied and not used yet.
We need major update to use the function since it changes the interface with
inifiles.Scope of influence
No effect
Supplement
NA
Note
NA