Skip to content

Commit

Permalink
Update gulp, language settings, and stored files (#102)
Browse files Browse the repository at this point in the history
## Describe your changes
I updated the language settings in `.eslintrc` to just look for browser
and node JS syntax and removed the watching of the `css` and `js`
folders since those are never being modified by users. The reason the
were removed other than that was because they will update since we are
always taking the latest files and it is a bit confusing from a user's
perspective. We need the files to be there, but we really don't care
what is in them as we presume the maintainers of the libraries have
checked.

**Bonus:** The format function now runs when you run the `gulp` command.

## Checklist before requesting a review
- [x] All features within the repository still work on my local dev
environment.

```bash
icj-project-rig % gulp dev
`import sass from 'sass'` is deprecated.
Please use `import * as sass from 'sass'` instead.
[00:31:25] Using gulpfile ~/Documents/GitHub/icj-project-rig/gulpfile.js
[00:31:25] Starting 'dev'...
[00:31:25] Starting 'default'...
[00:31:25] Starting 'clean'...
[00:31:25] Finished 'clean' after 3.78 ms
[00:31:25] Starting 'clean'...
[00:31:25] Starting 'styles'...
[00:31:25] Starting 'copy'...
[00:31:25] Starting 'nunjucks'...
[00:31:25] Starting 'bake'...
[00:31:25] Finished 'clean' after 660 μs
[00:31:25] Starting 'lint'...
[00:31:25] Starting 'scripts'...
[00:31:25] Starting 'images'...
[00:31:25] Finished 'nunjucks' after 123 ms
[00:31:25] Finished 'bake' after 125 ms
[00:31:26] Finished 'lint' after 356 ms
[00:31:28] gulp-imagemin: Minified 0 images
[00:31:28] Finished 'styles' after 3.04 s
[00:31:28] Finished 'scripts' after 2.92 s
[00:31:28] Finished 'copy' after 3.04 s
[00:31:28] Finished 'images' after 2.92 s
[00:31:28] Starting 'format'...
[00:31:28] File 'docs/books/the-clown.html' was not formatted with Prettier
[00:31:28] File 'docs/books/the-hearing-trumpet.html' was not formatted with Prettier
[00:31:28] File 'docs/books/the-shipping-news.html' was not formatted with Prettier
[00:31:28] File 'docs/index.html' was not formatted with Prettier
[00:31:28] Finished 'format' after 102 ms
[00:31:28] Finished 'default' after 3.15 s
[00:31:28] Starting 'serve'...
[Browsersync] Access URLs:
 --------------------------------------
       Local: http://localhost:3001
    External: http://192.168.0.116:3001
 --------------------------------------
          UI: http://localhost:3002
 UI External: http://localhost:3002
 --------------------------------------
[Browsersync] Serving files from: docs
```
  • Loading branch information
michplunkett authored Aug 16, 2023
1 parent 0837a72 commit c3325d8
Show file tree
Hide file tree
Showing 12 changed files with 79 additions and 10,755 deletions.
2 changes: 1 addition & 1 deletion .eslintrc.json
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
"parser": "@babel/eslint-parser",
"env": {
"browser": true,
"es2024": true
"node": true
},
"extends": ["eslint:recommended", "plugin:compat/recommended"],
"rules": {
Expand Down
5 changes: 4 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@

# Created by https://www.gitignore.io/api/node,macos,windows,visualstudiocode
# Edit at https://www.gitignore.io/?templates=node,macos,windows,visualstudiocode

Expand All @@ -8,6 +7,10 @@
.AppleDouble
.LSOverride

# Static code
/docs/css/
/docs/js/

# Google authorization files
application_default_credentials.json
service_account_key.json
Expand Down
7 changes: 0 additions & 7 deletions docs/css/main.css

This file was deleted.

7 changes: 0 additions & 7 deletions docs/js/bootstrap.bundle.min.js

This file was deleted.

1 change: 0 additions & 1 deletion docs/js/bootstrap.bundle.min.js.map

This file was deleted.

Loading

0 comments on commit c3325d8

Please sign in to comment.