Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address png compression issue #105

Merged
merged 4 commits into from
Aug 18, 2023
Merged

Address png compression issue #105

merged 4 commits into from
Aug 18, 2023

Conversation

michplunkett
Copy link
Contributor

@michplunkett michplunkett commented Aug 17, 2023

Describe your changes

There seems to be some issue with the newer versions of pngquant: imagemin/imagemin-pngquant#46 (comment)

Checklist before requesting a review

  • All features within the repository still work on my local dev environment.
michaelp@MacBook-Air-5 icj-project-rig % gulp        
`import sass from 'sass'` is deprecated.
Please use `import * as sass from 'sass'` instead.
[16:10:17] Using gulpfile ~/Documents/GitHub/icj-project-rig/gulpfile.js
[16:10:17] Starting 'default'...
[16:10:17] Starting 'clean'...
[16:10:17] Starting 'styles'...
[16:10:17] Starting 'copy'...
[16:10:17] Starting 'nunjucks'...
[16:10:17] Starting 'bake'...
[16:10:17] Finished 'clean' after 4 ms
[16:10:17] Starting 'lint'...
[16:10:17] Starting 'scripts'...
[16:10:17] Starting 'images'...
[16:10:17] Finished 'nunjucks' after 250 ms
[16:10:17] Finished 'bake' after 252 ms
[16:10:17] Finished 'lint' after 463 ms
[16:10:20] Finished 'styles' after 3.27 s
[16:10:20] Finished 'scripts' after 3.02 s
[16:10:20] Finished 'copy' after 3.27 s
[16:10:20] gulp-imagemin: Minified 0 images
[16:10:20] Finished 'images' after 3.03 s
[16:10:20] Starting 'format'...
[16:10:20] File 'docs/books/the-clown.html' was not formatted with Prettier
[16:10:20] File 'docs/books/the-hearing-trumpet.html' was not formatted with Prettier
[16:10:20] File 'docs/books/the-shipping-news.html' was not formatted with Prettier
[16:10:20] File 'docs/index.html' was not formatted with Prettier
[16:10:20] Finished 'format' after 102 ms
[16:10:20] Finished 'default' after 3.38 s
michaelp@MacBook-Air-5 icj-project-rig % 

Copy link
Contributor

@critmcdonald critmcdonald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works for me. Thanks.

@critmcdonald critmcdonald merged commit 02a819a into main Aug 18, 2023
2 checks passed
@michplunkett michplunkett deleted the pngprob branch August 18, 2023 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants