Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gazebo slam #116

Open
wants to merge 25 commits into
base: master
Choose a base branch
from
Open

Gazebo slam #116

wants to merge 25 commits into from

Conversation

jinsooPark-17
Copy link
Contributor

Testing a larger gazebo map that reflects GDC 3ne better.

  • doors_map.pgm, doors_map.yaml and doors_map_corpp.yaml remains unchanged.
    If those files are also needed to be changed, please contact me.

@maxsvetlik
Copy link
Member

You mentioned those files are unchanged, doors_map.yaml and doors_map_corpp.yaml have been altered with the same minor changes. doors_map.pgm has minor changes as well, but I'm not sure what they are.
Do they need their new value?

Also, can you revert the README to how it was before?

You can view the additions/deletions here

@maxsvetlik
Copy link
Member

@YuqianJiang since you use the segbot simulator regularly (I think?) I've added you as a reviewer as well

@jinsooPark-17
Copy link
Contributor Author

I revert Readme.md to that of the master branch.

Sorry for the confusion. I uploaded a larger but incorrect version of 'doors_map.pgm' and other files.
If someone needs those files, then one has to create doors_map.pgm & doors_map.yaml file based on the new 3ne.pgm file and door configuration of the new Gazebo world.

@maxsvetlik
Copy link
Member

After discussing it with @YuqianJiang, the best way to move forward integrating this world is to add it as a separate world, rather than replacing the existing world. This is to help keep consistency for people that have used the 'standard' simulator for their experiments in the past.

So this entails the following changes:

  1. all the 3ne.yaml and 3ne.dae and 3ne.pgm etc should be renamed to something like 3ne_scaled and get its own folder in utexas_gdc/maps/simulation/.
  2. The old 3ne.* files should be replaced with what is on the master branch.
  3. The simulation launch file(s) should be modified as appropriate to launch this new world.

You can see this PR to see an example of how I added an argument to the highest level of launch file, that then trickles down to launch the desired Gazebo world launch files which lives in the bwi_common repository. This does mean creating a separate branch in the bwi repository, and creating another PR there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants