Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Code Analyser #28

Open
wants to merge 19 commits into
base: main
Choose a base branch
from
Open

Added Code Analyser #28

wants to merge 19 commits into from

Conversation

BabyElias
Copy link

Solves Issue #4376

But, I need help regarding some diagnosed code issues in order to correct them.
image

@stnguyen90 stnguyen90 linked an issue Oct 13, 2022 that may be closed by this pull request
🔎 Add Code Analyzer To ‘utopia-php/analytics’ appwrite/appwrite#4376
Closed
5 tasks
@BabyElias
Copy link
Author

Made all corrections, reduced level to 6

@stnguyen90 stnguyen90 self-requested a review October 28, 2022 22:55
stnguyen90
stnguyen90 requested changes Oct 28, 2022
View reviewed changes
Copy link

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like there are a lot of syntax errors now.

.github/ISSUE_TEMPLATE/bug.yaml Outdated
- PHP 7.3.x
- PHP 7.4.x
- Different version (specify in environment)
- PHP 8.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please leave the "Different version..." option at the end.

src/Analytics/Adapter.php Outdated
* @throws \Exception
*/
public function call(string $method, string $path = '', array $headers = array(), array $params = array()): array|string
public function call(string $method, string $path = '', array $headers = array(), array $params = array()): array<int|string,mixed>|string
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like adding the <> stuff isn't supported and is causing some of the test errors.

@stnguyen90 stnguyen90 marked this pull request as draft October 28, 2022 23:09
@PineappleIOnic
Copy link
Member

Thank you so much for the PR 🤩. We're adding the hacktoberfest-accepted label to ensure this PR counts towards your Hacktoberfest contributions count. With that said, please stay active on this PR to address any comments once you receive a review. Happy Hacktoberfest! 🎃

@christyjacob4 christyjacob4 marked this pull request as ready for review February 16, 2023 13:46
@christyjacob4
Copy link
Contributor

@BabyElias thanks a lot for your contributions during Hacktoberfest 2022!

Please reach out to me on our Discord server if you would like to claim your Appwrite swags! As a way of saying thank you, we would also love to invite you to join the Appwrite organization on GitHub. Please share your GitHub username with us on Discord. 

There is still some work pending on this PR and I haven't got a chance to fix all the errors yet. Are you willing to continue this PR ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stnguyen90 stnguyen90 stnguyen90 requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

🔎 Add Code Analyzer To ‘utopia-php/analytics’
4 participants
@BabyElias @PineappleIOnic @christyjacob4 @stnguyen90