Dynamic attibute for related primary key #243
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…imary-key � Conflicts: � src/Database/Database.php
abnegate
reviewed
Aug 1, 2023
| @@ -1082,6 +1082,9 @@ protected function getSQLType(string $type, int $size, bool $signed = true): str | |||
|
|
|||
| return "VARCHAR({$size})"; | |||
|
|
|||
| case Database::VAR_ID: | |||
| return 'INT UNSIGNED'; // Same as Primary Key Sqlite does not allow INT(11) | |||
There was a problem hiding this comment.
Can we make this INT(11) and override for SQLite?
| @@ -253,6 +253,10 @@ public function isValid($document): bool | |||
| $validator = new Integer(); | |||
| break; | |||
|
|
|||
| case Database::VAR_ID: | |||
| $validator = new Text(24, min: 0); // Mongo Id length | |||
There was a problem hiding this comment.
I think this can be 36 for non-mongo adapters 🤔 how can we handle both?
|
Added an Asana task in the backlog |
Co-authored-by: Jake Barnby <jakeb994@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database::VAR_ID
Since some adapters primary key is a string and some is an int , we need a dynamic ID field per adapter