Feat 3996 bzip2 compression #89
Conversation
There was a problem hiding this comment.
Can we rename this file BZIP2Test.php?
|
|
||
| $this->assertEquals($this->object->decompress($data), $demo); | ||
| } | ||
|
|
There was a problem hiding this comment.
Can we add the testCompressDecompressWithLargeText() as seen in other compression tests?
| $this->assertEquals($demoSize, 3038056); | ||
| $this->assertEquals($dataSize, 2999345); | ||
|
|
||
| $this->assertGreaterThan($dataSize, $demoSize); |
| $this->assertEquals($demoSize, 599639); | ||
| $this->assertEquals($dataSize, 598565); | ||
|
|
||
| $this->assertGreaterThan($dataSize, $demoSize); |
There was a problem hiding this comment.
I don't think this is necessary
|
please give me hacktoberfest accepted tag i will update it soon |
|
Please don't spam. You already have the tag. |
|
Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback. We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions and/or ensure the tests pass by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event. |
|
Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship. Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag. |
|
my username akhilesh_32621 |
Create BZIP2 Compression Class and Unit Test
Description
This pull request introduces a new compression class to support BZIP2 compression and decompression, along with its accompanying unit test. The BZIP2 compression algorithm is now available for use in our storage library, enhancing its capabilities.
Installation Instructions (for Linux-based distributions)
Before using the BZIP2 compression class, you need to install the required dependency. You can do this using the following command on Linux-based distributions:
Testing command
Attached Screenshot
closes: appwrite/appwrite#3996