Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Cloudian Storage Adapter #92

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

nooras
Copy link

@nooras nooras commented Oct 8, 2023

What does this PR do?

This PR implements Cloudian Storage adapter

Test Plan

  1. Download this repository & install necessary package by
composer install
  1. To execute the Cloudian test suite, you will need certain below key. Please follow these steps:
    Get S3_ACCESS_KEY, S3_SECRET, CLOUDIAN_ACCESS_KEY, CLOUDIAN_SECRET and add run using below commands
    (I have implemented Cloudian Storage adapter based on S3. I searched on internet and found that Cloudian do supports S3)
S3_ACCESS_KEY="S3_ACCESS_KEY" S3_SECRET="S3_SECRET" CLOUDIAN_ACCESS_KEY="CLOUDIAN_ACCESS_KEY" CLOUDIAN_SECRET="CLOUDIAN_SECRET" ./vendor/bin/pint tests/Storage/Device/CloudianTest.php
  1. Unit test case of Cloudian
./vendor/bin/phpunit tests/Storage/Device/CloudianTest.php

image

Closes

#6411

Have you read the Contributing Guidelines on issues?

Yes

@gewenyu99
Copy link

@nooras make sure to run linters and fix tests!

@nooras
Copy link
Author

nooras commented Oct 19, 2023

@nooras make sure to run linters and fix tests!

Hi @gewenyu99
Can you please guide me on this?
How can i fix these issue? As I dont have any keys. I have followed examples present in storage repo.

In my local this test is running fine
image

I have removed unused import. Can you @gewenyu99 please review it once

@nooras
Copy link
Author

nooras commented Oct 31, 2023

@gewenyu99 @loks0n @wess
Anyone can please review this pr?

@gewenyu99
Copy link

Hey,

Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.

When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.

Thanks for helping us improve Appwrite!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants