Added support for CloudflareR2 Storage adaptar #97

Tushar98644 · 2023-10-19T09:50:33Z

fixes appwrite/appwrite#3352

Screenshots :

Tushar98644 · 2023-10-19T09:56:31Z

@stnguyen90 @gewenyu99 kindly review

bannu0snake · 2023-10-20T02:43:09Z

hi @Tushar98644 , can you please let me know how did you setup php and testing env in your mac. any reference links ?

Tushar98644 · 2023-10-20T13:27:08Z

hi @Tushar98644 , can you please let me know how did you setup php and testing env in your mac. any reference links ?

I just installed PHP and Composer,after installation you can add the project dependencies using composer install. You can have a look at the composer.json file , there you can find the scripts which used can be used to run the lining operations . For linting a file simply use composer format <file-path> and composer lint <file-path> to run the lining test

stnguyen90

Great PR! 🤯 We left some comments during the review, please check them out.

Please also make sure to run the test locally and attach a screenshot of the result.

src/Storage/Device/CloudflareR2.php

stnguyen90 · 2023-10-24T16:06:34Z

src/Storage/Device/CloudflareR2.php

+    public function __construct(string $root, string $accessKey, string $secretKey, string $bucket, string $region = self::APAC, string $acl = self::ACL_PRIVATE)
+    {
+        parent::__construct($root, $accessKey, $secretKey, $bucket, $region, $acl);
+        $this->headers['host'] = $bucket.'.'.'s3'.'.'.$region.'.cloudflarestorage.com';


Do you have any documentation on the host?

An S3 API URL looks like this:
https://accountid.r2.cloudflarestorage.com/bucketname

Where account id is your CF Account ID, like this:
https://905fa3fe223dcff4bf6b46911342bcfd.r2.cloudflarestorage.com/test

If you are using the EU Juristiction, you need to add .eu before the .r2, like this:
https://905fa3fe223dcff4bf6b46911342bcfd.eu.r2.cloudflarestorage.com/test

src/Storage/Device/CloudflareR2.php

src/Storage/Storage.php

tests/Storage/Device/CloudfareR2Test.php

.github/workflows/tests.yml

tests/Storage/Device/CloudfareR2Test.php

Tushar98644 · 2023-10-25T07:21:46Z

Great PR! 🤯 We left some comments during the review, please check them out.

Please also make sure to run the test locally and attach a screenshot of the result.

Do you mean the linting tests? I have attached a screenshot for the same in the pr description

Tushar98644 · 2023-10-28T11:41:12Z

@stnguyen90 any updates ?

stnguyen90

Some minor changes.

Please also address https://github.com/utopia-php/storage/pull/97/files#r1370466673

Do you mean the linting tests? I have attached a screenshot for the same in the pr description

No, I mean actual tests. Something that confirms this code actually works with Cloudflare R2 storage.

src/Storage/Device/CloudflareR2.php

.github/workflows/tests.yml

Co-authored-by: Steven Nguyen <1477010+stnguyen90@users.noreply.github.com>

Tushar98644 · 2023-10-31T16:17:13Z

Some minor changes.

Please also address https://github.com/utopia-php/storage/pull/97/files#r1370466673

Do you mean the linting tests? I have attached a screenshot for the same in the pr description

No, I mean actual tests. Something that confirms this code actually works with Cloudflare R2 storage.

I am having some issues with the card details and adding the r2 storage subscription to my account , would really appreciate it if you could test it from your side

gewenyu99 · 2023-10-31T23:21:49Z

Hey,

Due to time constraints, I'm going to mark this PR hacktoberfest-accepted for now so you get DO's Hacktoberfest rewards. We'll continue to work with you on this issue for review and merge.

When it is merged, we'll contact you for Appwrite-specific Hacktoberfest swag.

Thanks for helping us improve Appwrite!

stnguyen90 · 2023-10-31T23:43:30Z

I am having some issues with the card details and adding the r2 storage subscription to my account , would really appreciate it if you could test it from your side

How were you validating anything if you didn't have access to Cloudflare R2 storage?

stnguyen90 · 2023-10-31T23:41:14Z

src/Storage/Device/CloudflareR2.php

+    /**
+     * Regions constants
+     * Reference: https://developers.cloudflare.com/durable-objects/platform/data-location/
+     */
+
+    /**
+     * Regions constants
+     */


Please consolidate

Tushar98644 · 2023-11-04T12:39:30Z

I am having some issues with the card details and adding the r2 storage subscription to my account , would really appreciate it if you could test it from your side

How were you validating anything if you didn't have access to Cloudflare R2 storage?

I wasn't , i just followed the guide for adding a new adapter

docimin · 2023-11-14T09:05:54Z

Any update?

stnguyen90 · 2024-04-02T15:29:26Z

Closing as this doesn't actually work.

added CloudfareR2 adaptar

246fde0

Tushar98644 changed the title ~~Added support for CloudfareR2 adaptar~~ Added support for CloudfareR2 Storage adaptar Oct 19, 2023

stnguyen90 self-requested a review October 19, 2023 15:58

lint tests

9014289

stnguyen90 requested changes Oct 24, 2023

View reviewed changes

minor changes

b1944ab

Tushar98644 requested a review from stnguyen90 October 25, 2023 16:02

Tushar98644 changed the title ~~Added support for CloudfareR2 Storage adaptar~~ Added support for CloudflareR2 Storage adaptar Oct 26, 2023

stnguyen90 requested changes Oct 31, 2023

View reviewed changes

src/Storage/Device/CloudflareR2.php Show resolved Hide resolved

.github/workflows/tests.yml Outdated Show resolved Hide resolved

Tushar98644 and others added 2 commits October 31, 2023 21:40

Update CloudflareR2.php

fd7939b

Update .github/workflows/tests.yml

13c7cdb

Co-authored-by: Steven Nguyen <1477010+stnguyen90@users.noreply.github.com>

Tushar98644 requested a review from stnguyen90 October 31, 2023 16:17

gewenyu99 added the hacktoberfest-accepted label Oct 31, 2023

stnguyen90 requested changes Nov 1, 2023

View reviewed changes

github-actions bot mentioned this pull request Nov 1, 2023

PRs Opened in October 2023 appwrite/.github#93

Closed

stnguyen90 closed this Apr 2, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added support for CloudflareR2 Storage adaptar #97

Added support for CloudflareR2 Storage adaptar #97

Tushar98644 commented Oct 19, 2023 •

edited

Loading

Tushar98644 commented Oct 19, 2023 •

edited

Loading

bannu0snake commented Oct 20, 2023

Tushar98644 commented Oct 20, 2023 •

edited

Loading

stnguyen90 left a comment

stnguyen90 Oct 24, 2023

docimin Nov 16, 2023

Tushar98644 commented Oct 25, 2023

Tushar98644 commented Oct 28, 2023

stnguyen90 left a comment

Tushar98644 commented Oct 31, 2023

gewenyu99 commented Oct 31, 2023

stnguyen90 commented Oct 31, 2023

stnguyen90 Oct 31, 2023

Tushar98644 commented Nov 4, 2023

docimin commented Nov 14, 2023

stnguyen90 commented Apr 2, 2024

Added support for CloudflareR2 Storage adaptar #97

Added support for CloudflareR2 Storage adaptar #97

Conversation

Tushar98644 commented Oct 19, 2023 • edited Loading

Tushar98644 commented Oct 19, 2023 • edited Loading

bannu0snake commented Oct 20, 2023

Tushar98644 commented Oct 20, 2023 • edited Loading

stnguyen90 left a comment

Choose a reason for hiding this comment

stnguyen90 Oct 24, 2023

Choose a reason for hiding this comment

docimin Nov 16, 2023

Choose a reason for hiding this comment

Tushar98644 commented Oct 25, 2023

Tushar98644 commented Oct 28, 2023

stnguyen90 left a comment

Choose a reason for hiding this comment

Tushar98644 commented Oct 31, 2023

gewenyu99 commented Oct 31, 2023

stnguyen90 commented Oct 31, 2023

stnguyen90 Oct 31, 2023

Choose a reason for hiding this comment

Tushar98644 commented Nov 4, 2023

docimin commented Nov 14, 2023

stnguyen90 commented Apr 2, 2024

Tushar98644 commented Oct 19, 2023 •

edited

Loading

Tushar98644 commented Oct 19, 2023 •

edited

Loading

Tushar98644 commented Oct 20, 2023 •

edited

Loading