Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Exoscale adapter #99

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

Atharva1723
Copy link

@Atharva1723 Atharva1723 commented Oct 20, 2023

I have completed the partial implementation of the Exoscale adapter . Please review the PR and let me know what changes need to be made.

Related issue:

@Atharva1723
Copy link
Author

@stnguyen90 Can you review this PR?

@Atharva1723
Copy link
Author

Can this PR be reviewed? So that the necessary changes can be done by me

@stnguyen90 stnguyen90 changed the title [STORAGE]:Implementation of Exoscale adapter , Issue #6412 in appwrite repository Add Exoscale adapter Nov 1, 2023
@stnguyen90 stnguyen90 self-requested a review November 1, 2023 00:22
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great PR! 🤯 We left some comments during the review, please check them out.

Please make sure to run the formatter to fix the lint errors and attach screenshots of successful tests.

src/Storage/Device/Exoscale.php Show resolved Hide resolved
src/Storage/Device/Exoscale.php Outdated Show resolved Hide resolved
Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments.

In addition, please fix the lint errors and attach a screenshot of successful tests to the PR.

src/Storage/Device/Exoscale.php Outdated Show resolved Hide resolved
src/Storage/Device/Exoscale.php Outdated Show resolved Hide resolved
Atharva1723 and others added 2 commits November 1, 2023 15:56
Co-authored-by: Steven Nguyen <1477010+stnguyen90@users.noreply.github.com>
@Atharva1723
Copy link
Author

@stnguyen90 I have referred the configuration from https://community.exoscale.com/documentation/storage/quick-start/

Copy link
Contributor

@stnguyen90 stnguyen90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to run the formatter to fix the lint errors and attach screenshots of successful tests.

.github/workflows/tests.yml Outdated Show resolved Hide resolved
Co-authored-by: Luke B. Silver <22452787+loks0n@users.noreply.github.com>
@Atharva1723
Copy link
Author

Please make sure to run the formatter to fix the lint errors and attach screenshots of successful tests.

Where is the formatter ?

@loks0n
Copy link
Contributor

loks0n commented Nov 6, 2023

Where is the formatter ?

You can see the errors under the 'Checks' tab.

To run the formatter do composer run format

Please try to consult the CONTRIBUTING.md if you are stuck

@tessamero
Copy link

Hello @Atharva1723

Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback.

We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event.

Looking forward to your updates and thank you!

@Atharva1723
Copy link
Author

Hello @Atharva1723

Thank you for your contribution to Hacktoberfest 2023! We've noticed that your PR is still pending and requires some updates based on our engineering team's feedback.

We would love to see your PR successfully merged and send you the Appwrite swag as a token of appreciation. To remain eligible for the swag, please address the pending suggestions by Friday, November 17th. If the PR isn't updated by then, we will unfortunately have to close it due to the end of the Hacktoberfest event.

Looking forward to your updates and thank you!

I am working on the PR rn will commit the changes as soon as possible..

@Atharva1723
Copy link
Author

I have run the formatter.

@loks0n loks0n requested a review from stnguyen90 November 15, 2023 10:29
@Atharva1723 Atharva1723 requested a review from loks0n November 23, 2023 03:49
@gewenyu99
Copy link

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@Atharva1723
Copy link
Author

Atharva1723 commented Apr 9, 2024

Hey there! There were a lot of big PRs during this Hacktoberfest, and we wanted to give everyone ample time to collaborate with our engineering team. If you were able to merge your PRs during October, amazing. If it’s still not merged, don’t worry about it either. Either way, we’ve got your Hacktoberfest swag minted and ready to ship.

Please comment with your Discord username here so we can contact you about your shipping information to deliver your Hacktoberfest swag.

@gewenyu99 Here is my Discord username:

phoenixop17

.please let me know if you are not able to reach out to me via discord.Thank You 😄

@gewenyu99
Copy link

Adding your name to a big spreadsheet to reach out. Thanks for your patience!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants