Merge pull request #24 from utopia-php/fix-unauthorized-clone

Fix: Unahtorized clone
utopia-php · Aug 13, 2024 · eb9b7ea · eb9b7ea
2 parents 3084aa9 + 515e796
commit eb9b7ea
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.github/workflows/tests.yml b/.github/workflows/tests.yml
@@ -27,4 +27,4 @@ jobs:
 
     - name: Run Tests
       run: |
-        docker-compose exec -T tests vendor/bin/phpunit --configuration phpunit.xml tests
+        docker compose exec -T tests vendor/bin/phpunit --configuration phpunit.xml tests
diff --git a/src/VCS/Adapter/Git/GitHub.php b/src/VCS/Adapter/Git/GitHub.php
@@ -516,8 +516,9 @@ public function generateCloneCommand(string $owner, string $repositoryName, stri
         // URL encode the components for the clone URL
         $owner = urlencode($owner);
         $repositoryName = urlencode($repositoryName);
-        $accessToken = urlencode($this->accessToken);
-        $cloneUrl = "https://{$owner}:{$accessToken}@github.com/{$owner}/{$repositoryName}";
+        $accessToken = !empty($this->accessToken) ? ':' . urlencode($this->accessToken) : '';
+
+        $cloneUrl = "https://{$owner}{$accessToken}@github.com/{$owner}/{$repositoryName}";
 
         $directory = escapeshellarg($directory);
         $rootDirectory = escapeshellarg($rootDirectory);