fix: update dart commads #5
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -37,12 +37,12 @@ public function getFiles(): array | |||
|
|
|||
| public function getInstallCommand(): string | |||
| { | |||
| return 'flutter pub get'; | |||
| return 'dart pub get'; | |||
There was a problem hiding this comment.
I'm able to verify dart pub get but not dart build. I found dart run and webdev build --output web:build instead in the docs. @Meldiron @stnguyen90 any idea?
There was a problem hiding this comment.
We actually dont use these methods for install and build commands I think. Right?
There was a problem hiding this comment.
We have some in installation: https://github.com/appwrite/appwrite/blob/master/src/Appwrite/Migration/Version/V19.php#L629
stnguyen90
reviewed
Oct 3, 2023
| } | ||
|
|
||
| public function getBuildCommand(): string | ||
| { | ||
| return 'flutter build'; | ||
| return 'dart build'; |
There was a problem hiding this comment.
It would be something like dart compile. See https://github.com/open-runtimes/open-runtimes/blob/b6450aca19f6e95c319ba973422857610b718d3b/runtimes/dart-2.16/helpers/after-build.sh#L16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dart install and build commands were using the
fluttercommand which is a client side command unavailable in dart server side environments