Fix new clippy warnings #7524
Workflow file for this run
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| name: FreeBSD | |
| # spell-checker:ignore sshfs usesh vmactions taiki Swatinem esac fdescfs fdesc | |
| env: | |
| # * style job configuration | |
| STYLE_FAIL_ON_FAULT: true ## (bool) fail the build if a style job contains a fault (error or warning); may be overridden on a per-job basis | |
| on: | |
| pull_request: | |
| push: | |
| branches: | |
| - main | |
| permissions: | |
| contents: read # to fetch code (actions/checkout) | |
| # End the current execution if there is a new changeset in the PR. | |
| concurrency: | |
| group: ${{ github.workflow }}-${{ github.ref }} | |
| cancel-in-progress: ${{ github.ref != 'refs/heads/main' }} | |
| jobs: | |
| style: | |
| name: Style and Lint | |
| runs-on: ${{ matrix.job.os }} | |
| timeout-minutes: 90 | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| job: | |
| - { os: ubuntu-24.04 , features: unix } | |
| env: | |
| SCCACHE_GHA_ENABLED: "true" | |
| RUSTC_WRAPPER: "sccache" | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: Swatinem/rust-cache@v2 | |
| - name: Run sccache-cache | |
| uses: mozilla-actions/sccache-action@v0.0.6 | |
| - name: Prepare, build and test | |
| uses: vmactions/freebsd-vm@v1.1.5 | |
| with: | |
| usesh: true | |
| sync: rsync | |
| copyback: false | |
| # We need jq and GNU coreutils to run show-utils.sh and bash to use inline shell string replacement | |
| prepare: pkg install -y curl sudo jq coreutils bash | |
| run: | | |
| ## Prepare, build, and test | |
| # implementation modelled after ref: <https://github.com/rust-lang/rustup/pull/2783> | |
| # * NOTE: All steps need to be run in this block, otherwise, we are operating back on the mac host | |
| set -e | |
| # | |
| TEST_USER=tester | |
| REPO_NAME=${GITHUB_WORKSPACE##*/} | |
| WORKSPACE_PARENT="/home/runner/work/${REPO_NAME}" | |
| WORKSPACE="${WORKSPACE_PARENT}/${REPO_NAME}" | |
| # | |
| pw adduser -n ${TEST_USER} -d /root/ -g wheel -c "Coreutils user to build" -w random | |
| chown -R ${TEST_USER}:wheel /root/ "${WORKSPACE_PARENT}"/ | |
| whoami | |
| # | |
| # Further work needs to be done in a sudo as we are changing users | |
| sudo -i -u ${TEST_USER} bash << EOF | |
| set -e | |
| whoami | |
| curl https://sh.rustup.rs -sSf --output rustup.sh | |
| sh rustup.sh -y -c rustfmt,clippy --profile=minimal -t stable | |
| . ${HOME}/.cargo/env | |
| ## VARs setup | |
| cd "${WORKSPACE}" | |
| unset FAIL_ON_FAULT ; case '${{ env.STYLE_FAIL_ON_FAULT }}' in | |
| ''|0|f|false|n|no|off) FAULT_TYPE=warning ;; | |
| *) FAIL_ON_FAULT=true ; FAULT_TYPE=error ;; | |
| esac; | |
| FAULT_PREFIX=\$(echo "\${FAULT_TYPE}" | tr '[:lower:]' '[:upper:]') | |
| # * determine sub-crate utility list | |
| UTILITY_LIST="\$(./util/show-utils.sh --features ${{ matrix.job.features }})" | |
| CARGO_UTILITY_LIST_OPTIONS="\$(for u in \${UTILITY_LIST}; do echo -n "-puu_\${u} "; done;)" | |
| ## Info | |
| # environment | |
| echo "## environment" | |
| echo "CI='${CI}'" | |
| echo "REPO_NAME='${REPO_NAME}'" | |
| echo "TEST_USER='${TEST_USER}'" | |
| echo "WORKSPACE_PARENT='${WORKSPACE_PARENT}'" | |
| echo "WORKSPACE='${WORKSPACE}'" | |
| echo "FAULT_PREFIX='\${FAULT_PREFIX}'" | |
| echo "UTILITY_LIST='\${UTILITY_LIST}'" | |
| env | sort | |
| # tooling info | |
| echo "## tooling info" | |
| cargo -V | |
| rustc -V | |
| # | |
| # To ensure that files are cleaned up, we don't want to exit on error | |
| set +e | |
| unset FAULT | |
| ## cargo fmt testing | |
| echo "## cargo fmt testing" | |
| # * convert any errors/warnings to GHA UI annotations; ref: <https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message> | |
| S=\$(cargo fmt -- --check) && printf "%s\n" "\$S" || { printf "%s\n" "\$S" ; printf "%s\n" "\$S" | sed -E -n -e "s/^Diff[[:space:]]+in[[:space:]]+\${PWD//\//\\\\/}\/(.*)[[:space:]]+at[[:space:]]+[^0-9]+([0-9]+).*\$/::\${FAULT_TYPE} file=\1,line=\2::\${FAULT_PREFIX}: \\\`cargo fmt\\\`: style violation (file:'\1', line:\2; use \\\`cargo fmt -- \"\1\"\\\`)/p" ; FAULT=true ; } | |
| ## cargo clippy lint testing | |
| if [ -z "\${FAULT}" ]; then | |
| echo "## cargo clippy lint testing" | |
| # * convert any warnings to GHA UI annotations; ref: <https://help.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-a-warning-message> | |
| S=\$(cargo clippy --all-targets \${CARGO_UTILITY_LIST_OPTIONS} -- -W clippy::manual_string_new -D warnings 2>&1) && printf "%s\n" "\$S" || { printf "%s\n" "\$S" ; printf "%s" "\$S" | sed -E -n -e '/^error:/{' -e "N; s/^error:[[:space:]]+(.*)\\n[[:space:]]+-->[[:space:]]+(.*):([0-9]+):([0-9]+).*\$/::\${FAULT_TYPE} file=\2,line=\3,col=\4::\${FAULT_PREFIX}: \\\`cargo clippy\\\`: \1 (file:'\2', line:\3)/p;" -e '}' ; FAULT=true ; } | |
| fi | |
| # Clean to avoid to rsync back the files | |
| cargo clean | |
| if [ -n "\${FAIL_ON_FAULT}" ] && [ -n "\${FAULT}" ]; then exit 1 ; fi | |
| EOF | |
| test: | |
| name: Tests | |
| runs-on: ${{ matrix.job.os }} | |
| timeout-minutes: 90 | |
| strategy: | |
| fail-fast: false | |
| matrix: | |
| job: | |
| - { os: ubuntu-24.04 , features: unix } | |
| env: | |
| mem: 4096 | |
| SCCACHE_GHA_ENABLED: "true" | |
| RUSTC_WRAPPER: "sccache" | |
| steps: | |
| - uses: actions/checkout@v4 | |
| - uses: Swatinem/rust-cache@v2 | |
| - name: Run sccache-cache | |
| uses: mozilla-actions/sccache-action@v0.0.6 | |
| - name: Prepare, build and test | |
| uses: vmactions/freebsd-vm@v1.1.5 | |
| with: | |
| usesh: true | |
| sync: rsync | |
| copyback: false | |
| prepare: pkg install -y curl gmake sudo | |
| run: | | |
| ## Prepare, build, and test | |
| # implementation modelled after ref: <https://github.com/rust-lang/rustup/pull/2783> | |
| # * NOTE: All steps need to be run in this block, otherwise, we are operating back on the mac host | |
| set -e | |
| # | |
| # We need a file-descriptor file system to test test_ls::test_ls_io_errors | |
| mount -t fdescfs fdesc /dev/fd | |
| # | |
| TEST_USER=tester | |
| REPO_NAME=${GITHUB_WORKSPACE##*/} | |
| WORKSPACE_PARENT="/home/runner/work/${REPO_NAME}" | |
| WORKSPACE="${WORKSPACE_PARENT}/${REPO_NAME}" | |
| # | |
| pw adduser -n ${TEST_USER} -d /root/ -g wheel -c "Coreutils user to build" -w random | |
| # chown -R ${TEST_USER}:wheel /root/ "${WORKSPACE_PARENT}"/ | |
| chown -R ${TEST_USER}:wheel /root/ "${WORKSPACE_PARENT}"/ | |
| whoami | |
| # | |
| # Further work needs to be done in a sudo as we are changing users | |
| sudo -i -u ${TEST_USER} sh << EOF | |
| set -e | |
| whoami | |
| curl https://sh.rustup.rs -sSf --output rustup.sh | |
| sh rustup.sh -y --profile=minimal | |
| . $HOME/.cargo/env | |
| # Install nextest | |
| mkdir -p ~/.cargo/bin | |
| curl -LsSf https://get.nexte.st/latest/freebsd | tar zxf - -C ~/.cargo/bin | |
| ## Info | |
| # environment | |
| echo "## environment" | |
| echo "CI='${CI}'" | |
| echo "REPO_NAME='${REPO_NAME}'" | |
| echo "TEST_USER='${TEST_USER}'" | |
| echo "WORKSPACE_PARENT='${WORKSPACE_PARENT}'" | |
| echo "WORKSPACE='${WORKSPACE}'" | |
| env | sort | |
| # tooling info | |
| echo "## tooling info" | |
| cargo -V | |
| cargo nextest --version | |
| rustc -V | |
| # | |
| # To ensure that files are cleaned up, we don't want to exit on error | |
| set +e | |
| cd "${WORKSPACE}" | |
| unset FAULT | |
| cargo build || FAULT=1 | |
| export PATH=~/.cargo/bin:${PATH} | |
| export RUST_BACKTRACE=1 | |
| export CARGO_TERM_COLOR=always | |
| if (test -z "\$FAULT"); then cargo nextest run --hide-progress-bar --profile ci --features '${{ matrix.job.features }}' || FAULT=1 ; fi | |
| if (test -z "\$FAULT"); then cargo nextest run --hide-progress-bar --profile ci --all-features -p uucore || FAULT=1 ; fi | |
| # Clean to avoid to rsync back the files | |
| cargo clean | |
| if (test -n "\$FAULT"); then exit 1 ; fi | |
| EOF |