Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: windows port #42

Closed
wants to merge 1 commit into from
Closed

WIP: windows port #42

wants to merge 1 commit into from

Conversation

calixteman
Copy link

No description provided.

@sylvestre sylvestre changed the title WIP WIP: windows port Apr 2, 2024
@sylvestre
Copy link
Collaborator

@oSoMoN Would you be able to finish this PR ? :) thanks

@oSoMoN
Copy link
Collaborator

oSoMoN commented Apr 2, 2024

My experience with Windows is rusty (pun intended) at best, and I have no Windows machine handy, but I can take a look when time permits.

@oSoMoN
Copy link
Collaborator

oSoMoN commented Apr 4, 2024

@calixteman instead of a custom, platform-specific split_at_eol macro, why not use str::lines() from the standard library?

@oSoMoN oSoMoN mentioned this pull request Apr 20, 2024
@oSoMoN
Copy link
Collaborator

oSoMoN commented Apr 22, 2024

Per #3 (comment), I'm closing this PR.

@oSoMoN oSoMoN closed this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants