ci: use -Cinstrument-coverage instead of -Zprofile
#470
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cakebaker
force-pushed
the
ci_fix_code_coverage
branch
2 times, most recently
from
4dd8145 to
c4c14e1
Compare
sylvestre
force-pushed
the
ci_fix_code_coverage
branch
from
c4c14e1 to
82fd8e9
Compare
cakebaker
force-pushed
the
ci_fix_code_coverage
branch
12 times, most recently
from
0eb54a7 to
9dcb6a6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #470 +/- ##
===========================================
+ Coverage 66.89% 87.45% +20.55%
===========================================
Files 36 31 -5
Lines 4438 6697 +2259
Branches 984 299 -685
===========================================
+ Hits 2969 5857 +2888
+ Misses 1059 628 -431
+ Partials 410 212 -198 ☔ View full report in Codecov by Sentry. |
cakebaker
force-pushed
the
ci_fix_code_coverage
branch
2 times, most recently
from
dedd391 to
fc823e6
Compare
and use cargo-llvm-cov instead of grcov. Support for -Zprofile has been removed from Rust nightly: rust-lang/rust#131829
cakebaker
force-pushed
the
ci_fix_code_coverage
branch
from
fc823e6 to
bca84ba
Compare
|
grcov also supports -Cinstrument-coverage they use it upstream |
|
Yes, I know that |
|
I know upstream ( @marco-c ) very well ;) |
cakebaker
force-pushed
the
ci_fix_code_coverage
branch
3 times, most recently
from
27e7f63 to
f2ca2a9
Compare
cakebaker
force-pushed
the
ci_fix_code_coverage
branch
3 times, most recently
from
b61da49 to
b170cc7
Compare
cakebaker
force-pushed
the
ci_fix_code_coverage
branch
from
b170cc7 to
18dc8b2
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is an attempt to fix the "code coverage" job by using
-Cinstrument-coverageinstead of-Zprofilewhich has been removed from Rust nightly: rust-lang/rust#131829 . For this purpose,cargo-llvm-covis used instead ofgrcov.