Completed fw 103 homework #489
Conversation
There was a problem hiding this comment.
There are 2 errors that would stop this project from doing what is intended, but apart from that, there are only minor problems.
you should run formatting and linting before you push. If you've set up the github hooks, it should format and lint before every commit.
your branch name should be soft_999_... with a underscore.
you can move on to 104 after fixing the errors, and probably take on a ticket if you are interested.
| interrupt_init(); | ||
| soft_timer_init(); | ||
| gpio_init(); | ||
|
|
There was a problem hiding this comment.
gpio_it_init() needs to be called to enable interrupts from gpio pins
| } else { | ||
| LOG_DEBUG("Failed to read potentiomter data"); | ||
| } | ||
| delay_ms(200); |
There was a problem hiding this comment.
what is this delay for?
| .priority = INTERRUPT_PRIORITY_NORMAL, // | ||
| }; | ||
|
|
||
| gpio_init_pin(&potentiometer_addr, &pot_settings); |
There was a problem hiding this comment.
you also need to init the button pin to use it
| .pin = 6, | ||
| }; | ||
| // function to call when the button gets hit | ||
| static void button_interrupt_handler(const GpioAddress *addy, void *context) { |
There was a problem hiding this comment.
we prefix static methods with prv_ and global static variables with s_.
(addy is an interesting variable name, typo?)
| INTERRUPT_EDGE_FALLING, | ||
| &button_interrupt_handler, // what function to call | ||
| &potentiometer_addr // what to send the function | ||
| ); |
There was a problem hiding this comment.
here you are not using the void * context in your function anyway so its ok to pass in NULL.
format is also complaining about this ending parenthesis, I would put it straight after the last argument.
| &potentiometer_addr // what to send the function | ||
| ); | ||
| while (true) { | ||
| // let cpu run wild until interrupt. |
There was a problem hiding this comment.
you can add a wait() from wait.h here to save on processing time.
|
|
||
| int main(void) { | ||
| interrupt_init(); | ||
| soft_timer_init(); |
There was a problem hiding this comment.
I don't think soft timer is used in this project, you don't need to include and init it.
please review for accuracy.