Fwxv 211 write uv cutoff smoke tests #196

Taksh-041102 · 2023-06-14T19:46:56Z

No description provided.

JarvisWeng

Looks mostly good

JarvisWeng · 2023-06-20T18:30:37Z

projects/fw103_taksh/README.md

@@ -0,0 +1,16 @@
+<!--


Remove all your code not related to this ticket

Sorry, I didn't understand what you meant here.

Like fw103_taksh, hello_world all these files you included shouldn't be included in your PR.
You need to remove them

ah alright, noted!

JarvisWeng · 2023-06-20T18:30:47Z

projects/uv_cutoff/inc/uv_cutoff.h

@@ -4,3 +4,5 @@ typedef enum UVCutoffState {
  UV_CUTOFF_ACTIVE = 0,
  UV_CUTOFF_DISCONNECTED,
 } UVCutoffState;
+
+void uv_ligc() {}


What is this for?

I removed a backspace after uv_ligc to resolve an error which scons lint threw.

Sorry what was the error? I don't think uv_ligc is used anywhere

I changed uv_ligc () {} -> uv_ligc() {}.
scons lint said to remove an extra space after uv_ligc.

This is an entirely new line. It shouldn't be here if you're not using it

You should just delete this

I had forgot to make this change, it'll be their in the new PR.

JarvisWeng · 2023-06-20T18:37:04Z

smoke/uv_cutoff/src/main.c

+
+  if (get_horn_and_lights_horn_state() && !lights_check) {
+    status = gpio_set_state(&horn, GPIO_STATE_HIGH);
+    // if(status != STATUS_CODE_OK) {


You can keep the debug messages or remove the comments

What that means is remove all commented code. If you want to keep them, then uncomment them

got it, it'll be in the new push.

JarvisWeng · 2023-06-20T18:51:34Z

smoke/uv_cutoff/src/main.c

+TASK(smoke_task, TASK_MIN_STACK_SIZE) {
+  //
+  //TEST 1 - Disconnected UV status
+  gpio_set_state(&uv_status,GPIO_STATE_LOW);


Also if you could add a LOG_DEBUG before every test just so we know which test is being run

Haven't pushed it yet.

JarvisWeng · 2023-06-20T18:52:08Z

smoke/uv_cutoff/src/main.c

+  gpio_set_state(&uv_status,GPIO_STATE_LOW);
+  uv_smoke_logic();
+  assert( g_tx_struct.uv_cutoff_notification_signal1 == UV_CUTOFF_DISCONNECTED );
+  LOG_DEBUG("uv_cutoff notification signal set to 'UV_CUTOFF_DISCONNECTED'\n");


Also can you add a 1s delay after ever test? Makes it easier to see in hw

yup, made this change. Yet to push it.

JarvisWeng · 2023-06-25T23:07:25Z

projects/fw103_taksh/README.md

@@ -0,0 +1,16 @@
+<!--


Like fw103_taksh, hello_world all these files you included shouldn't be included in your PR.
You need to remove them

JarvisWeng · 2023-06-25T23:08:25Z

projects/uv_cutoff/inc/uv_cutoff.h

@@ -4,3 +4,5 @@ typedef enum UVCutoffState {
  UV_CUTOFF_ACTIVE = 0,
  UV_CUTOFF_DISCONNECTED,
 } UVCutoffState;
+
+void uv_ligc() {}


Sorry what was the error? I don't think uv_ligc is used anywhere

JarvisWeng · 2023-06-25T23:09:34Z

smoke/uv_cutoff/src/main.c

+#include "uv_cutoff_setters.h"
+
+// TODO(devAdhiraj): update with actual ports and pins
+#define UV_CUTOFF_PORT GPIO_PORT_A


You should look at the UV cutoff schematic to find out these pins. If you can't, then just put random ones for now to get your test passing though.

JarvisWeng · 2023-06-25T23:10:16Z

smoke/uv_cutoff/src/main.c

+
+  if (get_horn_and_lights_horn_state() && !lights_check) {
+    status = gpio_set_state(&horn, GPIO_STATE_HIGH);
+    // if(status != STATUS_CODE_OK) {


What that means is remove all commented code. If you want to keep them, then uncomment them

JarvisWeng · 2023-07-25T02:58:57Z

smoke/uv_cutoff/src/main.c


-  if (get_horn_and_lights_horn_state() && !lights_check) {


You should be keeping this. It's in the original uv_cutoff no?

Yup, it is. I see what you mean by treating like an input. noted!

JarvisWeng · 2023-07-25T02:59:20Z

smoke/uv_cutoff/src/main.c

-    // if(status != STATUS_CODE_OK) {
-    //   LOG_DEBUG("GPIO Horn State could not be set to low\n");
-    // }
+    g_rx_struct.horn_and_lights_horn_state = GPIO_STATE_LOW;


This should be treated like an input. So you should set it in the test, rather than in this function

okay, I'll make that change.

JarvisWeng · 2023-07-25T03:00:32Z

smoke/uv_cutoff/src/main.c

@@ -163,7 +160,7 @@ int main() {

  gpio_init();

-  gpio_init_pin(&uv_status, GPIO_INPUT_PULL_UP, GPIO_STATE_HIGH);
+  gpio_init_pin(&uv_status, GPIO_OUTPUT_PUSH_PULL, GPIO_STATE_HIGH);


Write a comment here saying that is should be GPIO_INPUT_PULL_UP , but you're faking that for now.

JarvisWeng

Looks good except that one line

JarvisWeng · 2023-07-26T16:25:59Z

projects/uv_cutoff/inc/uv_cutoff.h

@@ -4,3 +4,5 @@ typedef enum UVCutoffState {
  UV_CUTOFF_ACTIVE = 0,
  UV_CUTOFF_DISCONNECTED,
 } UVCutoffState;
+
+void uv_ligc() {}


You should just delete this

vagrant and others added 27 commits April 30, 2023 14:23

Complete task 1

f08c10e

Complete task 1

846d7f0

Taksh Parmar tasks commit

0031dbf

complete task 2

f0b7bb8

Task 2 complete(1)

c385f7a

Task 2 complete(with lint)

e598d03

Task 2 complete(linting done)

be4182d

Task 2 complete(2)

d2f7f36

Task 2 complete(2)

fa25204

Task 2 complete(2)

645f09d

Task 2 complete(2)

885badb

Task 2 complete(2)

1201d86

Task 2 complete(2)

b82110e

Task 2 Complete(2)

55146db

Task 2 Complete(2)

a0a2834

uv_cutoff smoke tests ready for eval

9f41013

uv_cutoff smoke tests ready for eval

89e883e

uv_cutoff smoke tests ready for eval

11ef0b1

uv_cutoff smoke tests ready for eval

806b845

uv_cutoff smoke tests ready for eval

a212c6d

fixed up scons

1a4b898

uv_cutoff smoke tests

24d2328

uv_cutoff smoke tests

c744062

uv_cutoff smoke tests

5908678

uv_cutoff smoke tests

fff6c95

uv_cutoff smoke tests

182048a

uv_cutoff smoke tests

d3f4b0d

JarvisWeng reviewed Jun 20, 2023

View reviewed changes

JarvisWeng reviewed Jun 25, 2023

View reviewed changes

Taksh-041102 and others added 2 commits June 26, 2023 13:51

uv_cutoff smoke tests ready

73f80d0

uv_cutoff smoke tests

53a5264

JarvisWeng reviewed Jul 25, 2023

View reviewed changes

vagrant added 2 commits July 25, 2023 19:01

uv cutoff smoke tests done

25d1e67

uv cutoff smoke tests done

125c69f

JarvisWeng approved these changes Jul 26, 2023

View reviewed changes

uv cutoff smoke tests done

1722a49

JarvisWeng merged commit d7f479c into main Jul 26, 2023
1 check passed

JarvisWeng deleted the FWXV-211-write-uv-cutoff-smoke-tests branch July 26, 2023 17:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fwxv 211 write uv cutoff smoke tests #196

Fwxv 211 write uv cutoff smoke tests #196

Taksh-041102 commented Jun 14, 2023

JarvisWeng left a comment

JarvisWeng Jun 20, 2023

Taksh-041102 Jun 21, 2023

JarvisWeng Jun 25, 2023

Taksh-041102 Jun 25, 2023

JarvisWeng Jun 20, 2023

Taksh-041102 Jun 21, 2023

JarvisWeng Jun 25, 2023

Taksh-041102 Jun 26, 2023

JarvisWeng Jul 11, 2023

JarvisWeng Jul 26, 2023

Taksh-041102 Jul 26, 2023

JarvisWeng Jun 20, 2023

JarvisWeng Jun 25, 2023

Taksh-041102 Jun 26, 2023

JarvisWeng Jun 20, 2023

Taksh-041102 Jun 26, 2023

JarvisWeng Jun 20, 2023

Taksh-041102 Jun 26, 2023

JarvisWeng Jun 25, 2023

JarvisWeng Jun 25, 2023

JarvisWeng Jun 25, 2023

JarvisWeng Jun 25, 2023

JarvisWeng Jul 25, 2023

Taksh-041102 Jul 25, 2023

JarvisWeng Jul 25, 2023

Taksh-041102 Jul 25, 2023

JarvisWeng Jul 25, 2023

Taksh-041102 Jul 25, 2023

JarvisWeng left a comment

JarvisWeng Jul 26, 2023

Fwxv 211 write uv cutoff smoke tests #196

Fwxv 211 write uv cutoff smoke tests #196

Conversation

Taksh-041102 commented Jun 14, 2023

JarvisWeng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

JarvisWeng left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment