-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed some minor issues #222
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for catching the issues in my fsm too. approving since it sounds like this fixes HW stuff but not 100% sure how the CAN changes came about
@@ -44,7 +44,7 @@ StatusCode run_can_tx_cycle() | |||
return STATUS_CODE_OK; | |||
} | |||
|
|||
TASK(CAN_RX, TASK_STACK_512) | |||
TASK(CAN_RX, TASK_MIN_STACK_SIZE) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these changes to reduce the memory usage? I'm guessing that's what we're running into on hardware?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea, after we fixed the changes in power, we were still running into issues when running all the tasks together. This was causing it to fail.
@@ -187,7 +187,7 @@ StatusCode init_power_fsm(PowerFsmStateId inital_state) { | |||
.num_transitions = NUM_POWER_TRANSITIONS, | |||
.initial_state = inital_state, | |||
}; | |||
fsm_shared_mem_init(); | |||
// fsm_shared_mem_init(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this commented out because it'll just be initialized once in main?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be getting initialized in line 48 in main.c. I ran the tests, but if theres an error with it later, it should present itself
Someone please verify If I counted up the number of transistions for power correctly