STRAT15-174 #29
Open
STRAT15-174 #29
+344
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @AthithiyaM looks like our Bing Maps API key is causing the tests to fail. We'll figure it out and then approve your pull request. Sorry about that. |
probro27
requested changes
Aug 1, 2023
There was a problem hiding this comment.
Hey @AthithiyaM Great job with the ticket. Overall the code works and looks correct. I have added a couple of things to review in the code.
Apart from that I apologize for the failing test cases due to BING API KEY authorization failing. I will take a look at it and get back to you.
…store request response
|
@AthithiyaM Can you pull the latest main from the repository and then push again. I have removed the workflow so the tests will pass and we can merge your PR |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@rodrigotiscareno