Driver profiling sim #30
Conversation
There was a problem hiding this comment.
@jinayang15 Great work with the simulation stuff. Seems really solid. Great job.
I understand the logic, but I feel it would be great if you could write a small README explaining the process of simulating, and some basic calculations you are making, plus random values.
Apart from that just ensure you use triple quotes for multi-line comments as I have highlighted in my review.
Great job and also add a picture of the plots in the PR description.
| import random | ||
| import names | ||
|
|
||
| #simulating driver data |
There was a problem hiding this comment.
Please use triple quotes for documenting multiple lines code logic or field descriptions.
For single line comments the # is fine, and add a space after the # and then write the comment.
| maxstop = 4 | ||
| deltat = 3/60 | ||
| num_drivers = 30 | ||
| ''' |
There was a problem hiding this comment.
Move the triple quotes before the initialization of values.
| class Driver: | ||
| #drivers - number of drivers | ||
| #inc - speed increment in km/h | ||
| drivers = 0 |
There was a problem hiding this comment.
Great use of static variables :)
|
@jinayang15 Pull latest main when pushing. I have removed the workflow so the tests will pass. |
@rodrigotiscareno