fix program detail values and review form #205

bowenzhu1 · 2023-08-31T01:04:24Z

Notion ticket link

[Ticket Name
](https://www.notion.so/uwblueprintexecs/134e1f159caa4f73939d11a700c325ad?v=39cf7d5a98384eb9af2bff2265d0ac8a&p=a067cae9ed874ef89de758e7776125a9&pm=s)

Implementation description

use formik for program detail values
also fixed some dashboard navigation/step setting

Steps to test

Test that icons are correctly aligned when program intake form is empty during program review section

What should reviewers focus on?

Checklist

My PR name is descriptive and in imperative tense
My commit messages are descriptive and in imperative tense. My commits are atomic and trivial commits are squashed or fixup'd into non-trivial commits
I have run the appropriate linter(s)
I have requested a review from the PL, as well as other devs who have background knowledge on this PR or who will be building on top of this PR

github-actions · 2023-08-31T01:08:03Z

Visit the preview URL for this PR (updated for commit e85876e):

https://childrens-aid-society--pr205-bowen-update-review-jlcq8dw5.web.app

_{(expires Mon, 16 Oct 2023 19:46:34 GMT)}

_{🔥 via Firebase Hosting GitHub Action 🌎}

_{Sign: 93f6cb7bff946a1edd29d684408e6d31442cf0b1}

Ezzhingy

it's still broken for me ://

bowenzhu1 · 2023-09-13T14:31:34Z

it's still broken for me ://

ah shoot i'll get back to this when i have the chance

Ezzhingy

lgtm! solid

* fix program detail values and review form * remove log * fix positioning of icons in program intake form --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca>

* visit.py for DELETE CRUD function * delete_visit implementation * delete_visit bug fixed * spelling error fix (attendace to attendance) * initial commit * initial * visit put endpoint implemented * added attendance_record_service.py interface * Update attendance sheet fields (#208) * finalized attendance sheet field changes * Perform linting * Remove month field from attendance sheet DTO * fixed linting --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> * Implement get by intake_id for all services relating to intake (#209) * get caregiver by id works * fix intake id * add caregiver itnerface * add child service works, and appending to intake works * get opi by intake id working * fix caregiver method * make caregiver like jenny's * get children working * refactored get children * providers work * fix caregivers * opi works * add column to daytime_contacts and add goals to intake * daytime contacts working * add interface * run linter * fix goals and tests * Update seed for better testing * made changes based on review * revert changes to program details --------- Co-authored-by: Eugene Zhang <zhang.eug@gmail.com> * fix program detail values and review form (#205) * fix program detail values and review form * remove log * fix positioning of icons in program intake form --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> * Merge db heads (#213) * Implement visit component skeleton (#202) * Implement visit component skeleton * fix linting * Fix small comments * fix linting issue * Wrapped exit arrow with button * lint * Kevin y/implement attendance record service (#210) * Created attendance sheet service, routes (in visit.py), and test * Fixed test b/c attendance sheet got updated * Fix edit caregiver to delete logic (#215) * Fit Intake Cases (#212) modified position, padding, and case width * Refactor case over routing to display proper case data (#214) * Add dynamic routing and data read on case overview * fix linting * change data saving for caseLead --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> * Implement Visit REST Endpoints (GET) (#211) * Create visit.py * Run linter and instantiate visit.py * Implement GET visits endpoints * Stylistic changes * Run linter * Make requested changes * Add interface descriptions & Fix Wordings (#220) * Fix sheet funciton name * Sheet interface chore * Sheet & Behavior chore * Fill in Additional Fields and Restructuring Object for GET Intake (#217) * got transportRequirements, schedulingRequirements, and suggestedStartDate working * everything working except child behaviour * make concerns work * run linter * implement PR changes * implemented pr changes pt 2 * lint code' * load cases in view all cases page (#219) * Fix: Replace lead with referringWorker (#223) Replace lead with worker * visit.py for DELETE CRUD function * delete_visit bug fixed * spelling error fix (attendace to attendance) * initial commit * initial * visit put endpoint implemented * pr changes * linting backend --------- Co-authored-by: Omer Adeel <57784751+omeradeel26@users.noreply.github.com> Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca> Co-authored-by: Jacqueline Fung <fungjsl@gmail.com> Co-authored-by: Eugene Zhang <zhang.eug@gmail.com> Co-authored-by: Bowen Zhu <43287170+bowenzhu1@users.noreply.github.com> Co-authored-by: Eugene Zhang <86681988+Ezzhingy@users.noreply.github.com> Co-authored-by: Kevin Yan <70108329+kevinasian122@users.noreply.github.com> Co-authored-by: Cindy Li <82128464+cindyhjli@users.noreply.github.com> Co-authored-by: JoshuaYe <joshua.ye@live.com> Co-authored-by: Jenny Vong <jenny_vong@outlook.com>

bowenzhu1 added 2 commits August 29, 2023 01:08

fix program detail values and review form

889eed3

remove log

203a990

Ezzhingy requested changes Sep 9, 2023

View reviewed changes

omera26 added 2 commits October 9, 2023 13:52

Merge branch 'main' into bowen/update-review-form-program-details

4386b51

fix positioning of icons in program intake form

e85876e

omeradeel26 force-pushed the bowen/update-review-form-program-details branch from 94013cb to e85876e Compare October 9, 2023 19:43

omeradeel26 requested a review from Ezzhingy October 9, 2023 19:48

Ezzhingy approved these changes Oct 10, 2023

View reviewed changes

omeradeel26 merged commit 6d4626d into main Oct 10, 2023
7 checks passed

omeradeel26 deleted the bowen/update-review-form-program-details branch October 10, 2023 02:17

odis43 pushed a commit that referenced this pull request Nov 23, 2023

fix program detail values and review form (#205)

9a3f83a

* fix program detail values and review form * remove log * fix positioning of icons in program intake form --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca>

odis43 pushed a commit that referenced this pull request Nov 23, 2023

fix program detail values and review form (#205)

65454b1

* fix program detail values and review form * remove log * fix positioning of icons in program intake form --------- Co-authored-by: Omer Adeel <oadeel@uwaterloo.ca>

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix program detail values and review form #205

fix program detail values and review form #205

bowenzhu1 commented Aug 31, 2023 •

edited by omeradeel26

Loading

github-actions bot commented Aug 31, 2023 •

edited

Loading

Ezzhingy left a comment

bowenzhu1 commented Sep 13, 2023

Ezzhingy left a comment

fix program detail values and review form #205

fix program detail values and review form #205

Conversation

bowenzhu1 commented Aug 31, 2023 • edited by omeradeel26 Loading

Notion ticket link

Implementation description

Steps to test

What should reviewers focus on?

Checklist

github-actions bot commented Aug 31, 2023 • edited Loading

Ezzhingy left a comment

Choose a reason for hiding this comment

bowenzhu1 commented Sep 13, 2023

Ezzhingy left a comment

Choose a reason for hiding this comment

bowenzhu1 commented Aug 31, 2023 •

edited by omeradeel26

Loading

github-actions bot commented Aug 31, 2023 •

edited

Loading