[oneMKL][spblas] add missing 'const' keyword for alpha, beta, and input array, and remove 'y' from input list in sparse::trsv() spec. #498
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ut array, and remove 'y' from input list in sparse::trsv() spec.
spencerpatty
approved these changes
Sep 8, 2023
aepanchi
pushed a commit
to aepanchi/oneAPI-spec
that referenced
this pull request
Oct 31, 2023
…ut array, and remove 'y' from input list in sparse::trsv() spec. (uxlfoundation#498)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal:
In this PR, I'd like to update some missing
constkeyword for constant parameters within the spec forspblasdomain in order to achieve consistency in the spec, and fix some minor information.Details:
constkeyword for constant parameters (e.g.alphaandbeta) in the APIs.constkeyword for input vector/matrix in some spblas APIs.yvector from the input list ofsparse::trsv()API spec, sinceyis not an input forsparse::trsv()API.