Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[OneMKL] Replace onemkl:: with oneapi::mkl:: #535

Merged
merged 7 commits into from
Jun 21, 2024
Merged

[OneMKL] Replace onemkl:: with oneapi::mkl:: #535

merged 7 commits into from
Jun 21, 2024

Conversation

vtavana
Copy link
Contributor

@vtavana vtavana commented Apr 26, 2024 •
edited
Loading

In this PR, onemkl:: is replaced ith oneapi::mkl:: for relevant parameters in OneMKL BLAS routines.
This PR also is fixing #534

@mmeterel
Copy link
Contributor

mmeterel commented Apr 26, 2024 •
edited
Loading

@vtavana Thanks for the PR. It looks good so far. Do you want to extend it to other parameters in other APIs as well?
For example onemkl::side left_right, should be oneapi::mkl::side left_right

@vtavana
replacing onemkl:: with oneapi::mkl::
62fc947 
This command was used to make the changes
find . -type f -name "*.rst" -print0 | xargs -0 sed -i 's/onemkl::/oneapi::mkl::/g'
@vtavana vtavana changed the title [OneMKL] fix type of transa and transb [OneMKL] Replace onemkl:: with oneapi::mkl:: Apr 26, 2024
@hjabird hjabird mentioned this pull request May 15, 2024
Open
andrewtbarker
andrewtbarker reviewed Jun 21, 2024
View reviewed changes
Copy link
Contributor

@andrewtbarker andrewtbarker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this fix! I've marked a few minor typos, after that I think this is ready to merge.

Apologies for the long delay in review.

source/elements/oneMKL/source/domains/blas/dgmm_batch.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/blas/dgmm_batch.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/blas/dgmm_batch.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/blas/dgmm_batch.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/blas/dgmm_batch.rst Outdated Show resolved Hide resolved
source/elements/oneMKL/source/domains/blas/dgmm_batch.rst Outdated Show resolved Hide resolved
vtavana and others added 6 commits June 21, 2024 14:09
@vtavana @andrewtbarker
Update source/elements/oneMKL/source/domains/blas/dgmm_batch.rst
f7fbb40 
Co-authored-by: Andrew T. Barker <andrew1.barker@intel.com>
@vtavana @andrewtbarker
Update source/elements/oneMKL/source/domains/blas/dgmm_batch.rst
0ed755a 
Co-authored-by: Andrew T. Barker <andrew1.barker@intel.com>
@vtavana @andrewtbarker
Update source/elements/oneMKL/source/domains/blas/dgmm_batch.rst
3910bc9 
Co-authored-by: Andrew T. Barker <andrew1.barker@intel.com>
@vtavana @andrewtbarker
Update source/elements/oneMKL/source/domains/blas/dgmm_batch.rst
c8dc433 
Co-authored-by: Andrew T. Barker <andrew1.barker@intel.com>
@vtavana @andrewtbarker
Update source/elements/oneMKL/source/domains/blas/dgmm_batch.rst
c8aad3b 
Co-authored-by: Andrew T. Barker <andrew1.barker@intel.com>
@vtavana @andrewtbarker
Update source/elements/oneMKL/source/domains/blas/dgmm_batch.rst
d51416e 
Co-authored-by: Andrew T. Barker <andrew1.barker@intel.com>
@andrewtbarker andrewtbarker merged commit 4ee6e71 into uxlfoundation:main Jun 21, 2024
3 checks passed
@andrewtbarker andrewtbarker mentioned this pull request Jun 21, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrewtbarker andrewtbarker andrewtbarker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vtavana @mmeterel @andrewtbarker