[try_put_and_wait] Part 8: Add implementation for key_matching join_node #1432
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…production' into dev/kboyarinov/try_put_and_wait_function_node
…function_node' into dev/kboyarinov/try_put_and_wait_buffering_nodes
…buffering_nodes' into dev/kboyarinov/try_put_and_wait_limiter_node
…limiter_node' into dev/kboyarinov/try_put_and_wait_join_node
…join_node' into dev/kboyarinov/try_put_and_wait_key_matching_join_node
…production' into dev/kboyarinov/try_put_and_wait_buffering_nodes
…buffering_nodes' into dev/kboyarinov/try_put_and_wait_limiter_node
…limiter_node' into dev/kboyarinov/try_put_and_wait_join_node
…join_node' into dev/kboyarinov/try_put_and_wait_key_matching_join_node
…production' into dev/kboyarinov/try_put_and_wait_join_node
…join_node' into dev/kboyarinov/try_put_and_wait_key_matching_join_node
…production' into dev/kboyarinov/try_put_and_wait_join_node
…join_node' into dev/kboyarinov/try_put_and_wait_key_matching_join_node
Base automatically changed from
dev/kboyarinov/try_put_and_wait_join_node
to
dev/kboyarinov/try_put_and_wait_production
August 19, 2024 08:28
…production' into dev/kboyarinov/try_put_and_wait_key_matching_join_node
vossmjp
reviewed
Aug 19, 2024
| char first[sizeof(T1)]; | ||
| T2 second; | ||
| char fill1[REM]; | ||
| template<class U> struct alignment_of { |
There was a problem hiding this comment.
The preceding comment should be moved or removed.
|
|
||
| #if __TBB_PREVIEW_FLOW_GRAPH_TRY_PUT_AND_WAIT | ||
| template <typename T1, typename T2, typename T3> | ||
| struct alignas(alignof(max_alignment_helper_t<T1, T2, T3>)) aligned_three { |
There was a problem hiding this comment.
I think "aligned_triple" is better than "aligned_three", since triple is more in line with pair.
| this->third = metainfo; | ||
|
|
||
| for (auto waiter : metainfo.waiters()) { | ||
| waiter->reserve(); |
There was a problem hiding this comment.
I don't think it matters, but I've noticed that you sometimes rely on the default value of 1 and other times are explicit about the 1. Is there some pattern to when you do or do not use the explicit value?
There was a problem hiding this comment.
There is no special pattern in this regard. I tried to use 1 as an explicit argument everywhere. Changed here and in the corresponding release.
Co-authored-by: Mike Voss <michaelj.voss@intel.com>
Co-authored-by: Mike Voss <michaelj.voss@intel.com>
kboyarinov
merged commit 1ce85d9
into
dev/kboyarinov/try_put_and_wait_production
22 checks passed
kboyarinov
deleted the
dev/kboyarinov/try_put_and_wait_key_matching_join_node
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Extend key_matching join_node with try_put_and_wait API + tests
Fixes # - issue number(s) if exists
Type of change
Choose one or multiple, leave empty if none of the other choices apply
Add a respective label(s) to PR if you have permissions
Tests
Documentation
Breaks backward compatibility
Notify the following users
List users with
@to send notificationsOther information