Implement missing logic in WildPatternMatcher + re-enable unit tests #1348
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The unit test was also extended to check additional case
uxmal
reviewed
May 29, 2024
src/Core/Lib/WildPatternMatcher.cs
Outdated
| } | ||
| } | ||
| } | ||
| return occ_P; | ||
| } | ||
|
|
||
| private bool isValidPos(int pos,int len,int nextPatternWildcards,int textLength) |
There was a problem hiding this comment.
Coding style: for consistency method names are Capitalized. Also, the comment inside the method could be made into a doc comment:
/// <summary>
/// Checks that a match at the position <paramref name="pos" /> is within the text.
/// </summary>| public void Wpm_Wildcard() | ||
| { | ||
| var dcp = new WildPatternMatcher(); | ||
| var x = dcp.FindDcp("abracadabraaska", "a**a"); | ||
| Assert.AreEqual(new[] { 0, 3 }, x.ToArray()); | ||
| Assert.AreEqual(new[] { 0, 7,11 }, x.ToArray()); |
There was a problem hiding this comment.
Consider making a separate test case Wpm_WildcardAtEnd
Apply the suggested comment change.
|
Looks good. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The unit test was also extended to check additional case for patterns ending with wildcard