Skip to content

Commit

Permalink
tui/term_ui.go: update import
Browse files Browse the repository at this point in the history
  • Loading branch information
Michael Skralivetsky committed Aug 8, 2020
1 parent 0669ba2 commit b57424d
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion httpblaster/tui/term_ui.go
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
package tui

import (
ui "github.com/sasile/termui"
ui "github.com/MichaelSkralivetsky/termui"
"github.com/v3io/http_blaster/httpblaster/config"
"runtime"
"strconv"
Expand Down

6 comments on commit b57424d

@MichaelSkralivetsky
Copy link

@MichaelSkralivetsky MichaelSkralivetsky commented on b57424d Aug 8, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meirleopold
FYI, changed this for now because using github.com/sasile/termui blaster build fails: https://jenkins-prod.iguazeng.com/job/http_blaster/94/console

 export GOPATH=/home/iguazio/gocode/
+ cd /home/iguazio/gocode/src/github.com/v3io/http_blaster
+ go get
# github.com/sasile/termui
../../sasile/termui/render.go:107:15: undefined: stack.ParseDump
../../sasile/termui/render.go:118:22: line.SrcLine undefined (type stack.Call has no field or method SrcLine)
../../sasile/termui/render.go:121:27: line.Func.PkgName undefined (type stack.Func has no field or method PkgName)
../../sasile/termui/render.go:133:24: line.Func.PkgName undefined (type stack.Func has no field or method PkgName)
../../sasile/termui/render.go:133:48: line.SrcLine undefined (type stack.Call has no field or method SrcLine)
../../sasile/termui/render.go:134:21: cannot call non-function line.Func.Name (type string)
Build step 'Execute shell' marked build as failure

@meirleopold
Copy link
Contributor

@meirleopold meirleopold commented on b57424d Aug 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are there major difference from https://github.com/gizak/termui?

@meirleopold
Copy link
Contributor

@meirleopold meirleopold commented on b57424d Aug 9, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MichaelSkralivetsky I think we should move using the original repo instead, WDYT?

@MichaelSkralivetsky
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meirleopold

i made following change in my fork in order to fix build failure: MichaelSkralivetsky/termui@f72beaf

are there major difference from https://github.com/gizak/termui?

yeah there are differences Sasi made from some reason in his fork

I think we should move using the original repo instead, WDYT?

sure, ideally yes, but it won't compile when using it as is due to the same differences in Sasi's fork

@meirleopold
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you try it? because it looks like Sasi had one commit and it looks like you removed all his code in yours

@MichaelSkralivetsky
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@meirleopold

Did you try it? because it looks like Sasi had one commit and it looks like you removed all his code in yours

yes, the difference is that Sasi branch is long behind original repo
feel free to try yourself

Please sign in to comment.