Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Bump preact signals #3109

Merged
merged 4 commits into from
Jan 2, 2025
Merged

chore: Bump preact signals #3109

merged 4 commits into from
Jan 2, 2025

Conversation

Artur-
Copy link
Member

@Artur- Artur- commented Jan 2, 2025

Major version 3 drops support for auto tracking, not in use in Hilla anymore

Major version 3 drops support for auto tracking, not in use in Hilla anymore
@Artur- Artur- enabled auto-merge (squash) January 2, 2025 09:48
Copy link

codecov bot commented Jan 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.57%. Comparing base (567ad7e) to head (8157f92).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3109   +/-   ##
=======================================
  Coverage   92.57%   92.57%           
=======================================
  Files          85       85           
  Lines        3164     3164           
  Branches      775      775           
=======================================
  Hits         2929     2929           
  Misses        183      183           
  Partials       52       52           
Flag Coverage Δ
unittests 92.57% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Artur- Artur- requested a review from cromoteca January 2, 2025 13:20
@cromoteca
Copy link
Contributor

Are you sure that auto tracking is no longer needed? I remember that some discussion was still ongoing. @Legioth?

@Artur-
Copy link
Member Author

Artur- commented Jan 2, 2025

Yes, it does not work properly and it does not support React 19

@Artur-
Copy link
Member Author

Artur- commented Jan 2, 2025

If it was needed, presumably this build would have failed

Copy link
Contributor

@cromoteca cromoteca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should no longer be needed indeed. It's easy to revert anyway in case of problems.

@Legioth
Copy link
Member

Legioth commented Jan 2, 2025

It was still used by accident a while ago but I assume that has been fixed.

Copy link

sonarqubecloud bot commented Jan 2, 2025

@Artur- Artur- merged commit 4a18054 into main Jan 2, 2025
17 checks passed
@Artur- Artur- deleted the bump-preact branch January 2, 2025 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants