-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump preact signals #3109
Conversation
Major version 3 drops support for auto tracking, not in use in Hilla anymore
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3109 +/- ##
=======================================
Coverage 92.57% 92.57%
=======================================
Files 85 85
Lines 3164 3164
Branches 775 775
=======================================
Hits 2929 2929
Misses 183 183
Partials 52 52
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Are you sure that auto tracking is no longer needed? I remember that some discussion was still ongoing. @Legioth? |
Yes, it does not work properly and it does not support React 19 |
If it was needed, presumably this build would have failed |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should no longer be needed indeed. It's easy to revert anyway in case of problems.
It was still used by accident a while ago but I assume that has been fixed. |
Quality Gate passedIssues Measures |
Major version 3 drops support for auto tracking, not in use in Hilla anymore