add missing event property

vaadin · Sep 11, 2024 · 02ffeec · 02ffeec
1 parent ea86172
commit 02ffeec
Show file tree

Hide file tree

Showing 4 changed files with 6 additions and 2 deletions.
diff --git a/dev/dashboard.html b/dev/dashboard.html
@@ -105,7 +105,7 @@
  });
 
  dashboard.addEventListener('dashboard-item-resize-start', (e) => {
- console.log('dashboard-item-resize-start');
+ console.log('dashboard-item-resize-start', e.detail);
  });
 
  dashboard.addEventListener('dashboard-item-drag-resize', (e) => {

diff --git a/packages/dashboard/src/widget-resize-controller.js b/packages/dashboard/src/widget-resize-controller.js
@@ -46,7 +46,7 @@ export class WidgetResizeController extends EventTarget {
  this.__resizeHeight = this.__resizeStartHeight + e.detail.dy;
  this.__updateWidgetStyles();
 
- this.host.dispatchEvent(new CustomEvent('dashboard-item-resize-start'));
+ this.host.dispatchEvent(new CustomEvent('dashboard-item-resize-start', { detail: { item: this.resizedItem } }));
 
  this.__resizedElement = e.target;
  // Observe the removal of the resized element from the DOM

diff --git a/packages/dashboard/test/dashboard-widget-resizing.test.ts b/packages/dashboard/test/dashboard-widget-resizing.test.ts
@@ -259,6 +259,9 @@ describe('dashboard - widget resizing', () => {
  await nextFrame();
 
  expect(resizeStartSpy).to.have.been.calledOnce;
+ expect(resizeStartSpy.getCall(0).args[0].detail).to.deep.equal({
+ item: { id: 0 },
+ });
  });
 
  it('should dispatch an item drag resize event', async () => {

diff --git a/packages/dashboard/test/typings/dashboard.types.ts b/packages/dashboard/test/typings/dashboard.types.ts
@@ -62,6 +62,7 @@ narrowedDashboard.addEventListener('dashboard-item-drag-reorder', (event) => {
 
 narrowedDashboard.addEventListener('dashboard-item-resize-start', (event) => {
  assertType<DashboardItemResizeStartEvent<TestDashboardItem>>(event);
+ assertType<TestDashboardItem>(event.detail.item);
 });
 
 narrowedDashboard.addEventListener('dashboard-item-resize-end', (event) => {